Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm): Possibility to override zfs encryption keys directory #487

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix(helm): Possibility to override zfs encryption keys directory #487

merged 1 commit into from
Nov 16, 2023

Conversation

trunet
Copy link
Contributor

@trunet trunet commented Nov 15, 2023

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?: Being able to deploy in distributions with /home mounted as read-only.

What this PR does?: Add a value to helm charts to be able to set a hardcoded location.

Does this PR require any upgrade changes?: No

If the changes in this PR are manually verified, list down the scenarios covered:: I manage to install on a distribution with /home mounted as read-only, just setting zfsNode.encrKeysDir to something else.

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes The Helm chart and the encr-keys volume #477
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@trunet
fix(helm): Possibility to override zfs encryption keys directory
15ef65d 
Helm charts was hardcoding zfs encryption keys directory and on some
distributions /home is read-only. This commit will make it possible to
set it as a helm value.

Fixes openebs#477

Signed-off-by: Wagner Sartori Junior <wsartori@wsartori.com>
@trunet trunet mentioned this pull request Nov 15, 2023
Closed
@hrudaya21 hrudaya21 merged commit f3acaa5 into openebs:develop Nov 16, 2023
2 checks passed
@lazyIoad lazyIoad mentioned this pull request Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrudaya21 hrudaya21 hrudaya21 approved these changes

@niladrih niladrih niladrih approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Helm chart and the encr-keys volume
3 participants
@trunet @hrudaya21 @niladrih