fix(helm): Possibility to override zfs encryption keys directory #487
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helm charts was hardcoding zfs encryption keys directory and on some distributions /home is read-only. This commit will make it possible to set it as a helm value. Fixes openebs#477 Signed-off-by: Wagner Sartori Junior <wsartori@wsartori.com>
trunet
force-pushed
the
fix-encr-keys-volume
branch
from
32a8942
to
15ef65d
Compare
hrudaya21
approved these changes
Nov 16, 2023
niladrih
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?: Being able to deploy in distributions with /home mounted as read-only.
What this PR does?: Add a value to helm charts to be able to set a hardcoded location.
Does this PR require any upgrade changes?: No
If the changes in this PR are manually verified, list down the scenarios covered:: I manage to install on a distribution with /home mounted as read-only, just setting
zfsNode.encrKeysDirto something else.Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
encr-keysvolume #477<type>(<scope>): <subject>