Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(charts): move CRDs into a subchart #512

Closed
wants to merge 5 commits into from
Closed

refactor(charts): move CRDs into a subchart #512

wants to merge 5 commits into from

Conversation

niladrih
Copy link
Member

@niladrih niladrih commented Mar 16, 2024 •
edited
Loading

Changes:

  • bumps chart version, appVersion, image tag.
  • moves CRDs into a subchart and adds templating to enable/disable them, while maintaining install order. Install order matters for CRDs in case there are CRs inside the chart which may require the CRDs.
  • Add templating to CRDs which disables their installation if they already exist. Because the CRDs are inside the template directory of the subchart, they will carry the release-name label from helm. This makes them difficult to patch into an existing CRD in the cluster. The install/upgrade errors out in these cases. The templating will make sure the CRDs will be installed only if they are not present.

PRs with similar change:

@niladrih
feat(charts): bump chart version and image tag
ceaa415 
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
@niladrih niladrih added the pr/hold-merge hold the merge. label Mar 16, 2024
@niladrih niladrih force-pushed the 4.0-chart branch 2 times, most recently from 1f198a0 to 9b8a95a Compare March 16, 2024 19:25
@niladrih niladrih mentioned this pull request Mar 16, 2024
Merged
@niladrih
refactor(charts): move CRDs into a subchart
fef0fb7 
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
@niladrih
ci: update workflows
06ccc4a 
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
@niladrih
fix(charts): {{- end }} after document separator
d468819 
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
@niladrih
refactor(charts): simplify CRD helm chart values
b4e95ee 
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
@Abhinandan-Purkait
Copy link
Member

Has been picked in #513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@tiagolobocastro tiagolobocastro Awaiting requested review from tiagolobocastro

@avishnu avishnu Awaiting requested review from avishnu

@sinhaashish sinhaashish Awaiting requested review from sinhaashish

@hrudaya21 hrudaya21 Awaiting requested review from hrudaya21

Assignees
No one assigned
Labels
pr/hold-merge hold the merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@niladrih @Abhinandan-Purkait