This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
feat: Updated devstack mysql 5.7 to 8 #1094
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 13, 2023 03:13
matthugs
reviewed
Jun 13, 2023
| @@ -28,6 +28,9 @@ done | |||
| # Run edxapp migrations first since they are needed for the service users and OAuth clients | |||
| # docker-compose exec -T lms bash -e -c 'source /edx/app/edxapp/edxapp_env && cd /edx/app/edxapp/edx-platform && paver update_db --settings devstack_docker' | |||
|
|
|||
| echo -e "Change MySQL Host to mysql80" | |||
| docker-compose exec -T lms bash -e -c 'find /edx/ -type f -exec sed -i 's/mysql57/mysql80/g' {} +' | |||
There was a problem hiding this comment.
this quoting scheme looks wrong. Do we want single-quotes for the sed command?
There was a problem hiding this comment.
also more generally why are we attempting to find-and-replace here at provision-time rather than in source code?
There was a problem hiding this comment.
@matthugs This was just to verify that provisioning test work. This PR will not merge. That was work around to verify that images need updates for mysql hosts for the provisioning test to pass. The last commit in this PR passed the tests.
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated mysql 5.7 to mysql 8 for new dev stack setup
I've completed each of the following or determined they are not applicable: