Managing Front-End Dependencies with Bower #158
Conversation
|
So much red! Nice. My favorite kind of Pull Request. |
| @@ -0,0 +1,20 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Minor: Use #!/usr/bin/env bash instead.
There was a problem hiding this comment.
Why the switch? I have never seen your recommended shebang line.
There was a problem hiding this comment.
You haven't seen it because you probably haven't been exposed to many
flavors of linux/unix systems.
Some linux/unix distributions/releases don't use bash as the default
shell, or have different locations for bash (/bin/bash,
/usr/bin/bash, etc). env however is almost always located at
/usr/bin/env.
On Tue, Oct 7, 2014 at 1:05 PM, Clinton Blackburn notifications@github.com
wrote:
In bower-post-install.sh:
@@ -0,0 +1,20 @@
+#!/bin/bashWhy the switch? I have never seen your recommended shebang line.
—
Reply to this email directly or view it on GitHub
https://github.com/edx/edx-analytics-dashboard/pull/158/files#r18533448.
Carlos Andrés Rocha
www.edx.org
|
Travis is failing. Apart from a couple of minor things, it looks good to me. |
Managing Front-End Dependencies with Bower
Review and merge #121 first. Replaces #156