This repository has been archived by the owner on May 1, 2024. It is now read-only.
Updated Course ID Regex and CSV filename #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regex is nearly identical to the one used by LMS. The only difference is the internal capture groups have been replaced with character sets to avoid issues with the Swagger UI attempting to parse the internal capture groups and pass them along as arguments.
| self.generate_data(course_id) | ||
| filename = u'{0}--{1}.csv'.format(u'edX-DemoX-Demo_Course', self.csv_filename_slug) | ||
| self.assertCSVIsValid(course_id, filename) | ||
|
|
There was a problem hiding this comment.
Can you add a test that uses a valid unicode character in the new-format course-id? It would be good to know sooner rather than later that we handle this case.
There was a problem hiding this comment.
@brianhw I will test Unicode support in a later PR.
|
Looks good. Just add a test and 👍 |
File names are now compatible with opaque keys.
clintonb
added a commit
that referenced
this pull request
Oct 15, 2014
Updated Course ID Regex and CSV filename
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regex is nearly identical to the one used by LMS. The only difference is the internal capture groups have been replaced with character sets to avoid issues with the Swagger UI attempting to parse the internal capture groups and pass them along as arguments.
@rocha @dsjen @mulby @brianhw