Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

fix: omit transform of ids for event sink #40

Merged
merged 1 commit into from
Sep 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion event_sink_clickhouse/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
A sink for Open edX events to send them to ClickHouse.
"""

__version__ = "0.2.0"
__version__ = "0.2.1"
6 changes: 3 additions & 3 deletions event_sink_clickhouse/sinks/base_sink.py
Original file line number Diff line number Diff line change
Expand Up @@ -297,14 +297,14 @@ def fetch_target_items(self, ids=None, skip_ids=None, force_dump=False):
if ids:
item_keys = [self.convert_id(item_id) for item_id in ids]
else:
item_keys = [self.convert_id(item.id) for item in self.get_queryset()]
item_keys = [item.id for item in self.get_queryset()]

skip_ids = (
[self.convert_id(item_id) for item_id in skip_ids] if skip_ids else []
[str(item_id) for item_id in skip_ids] if skip_ids else []
)

for item_key in item_keys:
if item_key in skip_ids:
if str(item_key) in skip_ids:
yield item_key, False, f"{self.name} is explicitly skipped"
elif force_dump:
yield item_key, True, "Force is set"
Expand Down
Loading