This repository has been archived by the owner on Jun 2, 2023. It is now read-only.
fix: resolve ValueError in repo_checks label application #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes openedx-unsupported#60 I had tested the --dry-run but not the --no-dry-run code path. Just needed to update the arguments to the create_issue API call. For good measure, I also update both create_ and update_ API calls to use only kwargs.
kdmccormick
changed the title
kdmccormick
commented
May 19, 2023
| self.org_name, | ||
| self.repo_name, | ||
| label, | ||
| self.labels[label], |
There was a problem hiding this comment.
The actual bug:
Before, label was just a dict name, and self.labels was a dict mapping name -> color.
After #60 , label is a dict, but I didn't update this API call to account for that.
feanil
approved these changes
May 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60
I had tested the --dry-run but not the --no-dry-run code path.
Just needed to update the arguments to the create_issue API call.
For good measure, I also update both create_ and update_ API calls to use only kwargs.