Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix data tests #104

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Conversation

saraburns1
Copy link
Contributor

Fixing and updating data tests in preparation of adding unit tests

  1. Added new 'acceptable_values_xapi' test to run on models that don't exist in the target schema (reporting)
  2. Update 'tests' property to 'data_tests' per dbt documentation

@bmtcril
Copy link
Contributor

bmtcril commented Jun 18, 2024

Thanks for the fixes! It looks like we're not actually running tests as part of CI right now, can you add another step to the workflow? https://github.com/openedx/aspects-dbt/blob/main/.github/workflows/coverage.yml

I think we just need to add this before the "Check docs coverage" step:

      - name: Check dbt tests
        run: |
          dbt run
          dbt test

@bmtcril bmtcril merged commit aa58bd7 into openedx:main Jun 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants