feat: create fact_watched_video_segments report #86
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
| CONCAT( | ||
| toString(start_position), '-', toString(start_position + 4) | ||
| ) as segment_range, |
There was a problem hiding this comment.
I think this should use segment_start instead of start_position. start_position signifies when in a video a learner started watching, not the start of the 5-second segment that they watched.
For example, if I watched a video from 0 seconds to 20 seconds, this would produce four rows where segment_range is 0-4.
| join | ||
| {{ ref("dim_user_pii") }} dpi | ||
| on enriched_segments.actor_id = toString(dpi.external_user_id) |
There was a problem hiding this comment.
When I ran this locally, I noticed that my demo course data is excluded from this dataset. Are there cases where this join might be excluding learners?
There was a problem hiding this comment.
Yes, this join is wrong. Thanks you for catching that
|
@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR imports the model fact_watched_video_segments from Aspects to DBT