Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move problem engagement MVs #93

Merged
merged 5 commits into from
May 23, 2024
Merged

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented May 15, 2024

Description

This PR moves the problem engagement to an MV. A testing model called fact_problem_engagement_v2 has been created to compare the old model to the new one.

In the new model, records with empty section_subsection_name are skipped.

Author concerns

The data in the new MVs will only be updated once a new problem event is triggered

@openedx-webhooks
Copy link

openedx-webhooks commented May 15, 2024

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 15, 2024
@Ian2012 Ian2012 force-pushed the cag/mv-blocks branch 2 times, most recently from 704a6d3 to c8360f2 Compare May 15, 2024 20:06
@Ian2012 Ian2012 marked this pull request as ready for review May 15, 2024 20:14
@Ian2012 Ian2012 changed the title feat: move problem engagement to an mv feat: move problem engagement MVs May 15, 2024
@bmtcril
Copy link
Contributor

bmtcril commented May 22, 2024

This seems ok to me, once fact_problem_engagement_v2 is renamed. It seems like the downstream problem engagement reports will all need to be changed to use the new models?

@Ian2012 Ian2012 force-pushed the cag/mv-blocks branch 2 times, most recently from 3a6813a to e539789 Compare May 22, 2024 21:32
feat: move problem engagement to an mv

feat: move problem engagement to an mv

feat: move problem engagement to an mv

feat: move problem engagement to an mv

feat: add subsection block id to items per subsection

feat: add subsection block id to items per subsection

fix: use section_id for section problem engagement

fix: use section_id for section problem engagement

fix: use section_id for section problem engagement

fix: use section_id for section problem engagement

fix: use section_id for section problem engagement
@Ian2012 Ian2012 merged commit 2e86e13 into cag/problem-performance May 23, 2024
3 checks passed
@Ian2012 Ian2012 deleted the cag/mv-blocks branch May 23, 2024 19:09
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants