feat: Use LowCardinality for smaller columns #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmtcril
force-pushed
the
bmtcril/update_instance_mvs
branch
4 times, most recently
from
d87c0e2
to
33530af
Compare
Generally for columns with less than 10k unique values this provides a noticable performance benefit.
These currently get bogged down on large datasets, when querying across all time. This is an attempt to speed things up.
bmtcril
force-pushed
the
bmtcril/update_instance_mvs
branch
from
6e67e55
to
84a6531
Compare
Ian2012
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally for columns with less than 10k unique values this provides a noticeable performance benefit.
Accompanying PR is here: openedx/tutor-contrib-aspects#839