Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: running tests using python 3.11 #297

Merged
merged 6 commits into from
Apr 1, 2024
Merged

build: running tests using python 3.11 #297

merged 6 commits into from
Apr 1, 2024

Conversation

awais786
Copy link
Contributor

@awais786 awais786 commented Feb 12, 2024

openedx/public-engineering#236

Running tests using python 3.11.

@@ -161,7 +161,7 @@ requests==2.31.0
# -r requirements/base.txt
# requests-oauthlib
# social-auth-core
requests-oauthlib==1.3.1
requests-oauthlib==2.0.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes seems fine here

@awais786 awais786 changed the title build: running tests using python 3.11 and 3.12 build: running tests using python 3.11 Mar 28, 2024
Copy link
Member

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions, otherwise looking good to be merged.

@@ -14,8 +14,8 @@ jobs:
strategy:
matrix:
os: [ubuntu-20.04]
python-version: ['3.8']
toxenv: [quality, django32, django42, check_keywords]
python-version: ['3.8', '3.11', '3.12']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are upgrading to Python 3.11 now, we can skip running tests with 3.12 for now.

Suggested change
python-version: ['3.8', '3.11', '3.12']
python-version: ['3.8', '3.11']

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since the tests are passing on both, we should run both, we'll want to drop 3.11 after we cut redwood almost immediately so best to start testing 3.12 where it's already passing.

CHANGELOG.rst Outdated
Added
~~~~~~~

[4.3.0] - 2024-02-13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[4.3.0] - 2024-02-13
[4.3.0] - 2024-03-29

setup.py Outdated Show resolved Hide resolved
@feanil feanil merged commit 7f09ecb into master Apr 1, 2024
13 checks passed
@feanil feanil deleted the python-vers branch April 1, 2024 14:46
@feanil feanil mentioned this pull request Apr 1, 2024
6 tasks
@feanil feanil linked an issue Apr 1, 2024 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Test auth-backends on Python 3.11
4 participants