Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test codejail on Python 3.11 #165

Closed
4 of 6 tasks
Tracked by #34229
feanil opened this issue Mar 25, 2024 · 7 comments · Fixed by #167, openedx/edx-platform#34657 or #169
Closed
4 of 6 tasks
Tracked by #34229

Test codejail on Python 3.11 #165

feanil opened this issue Mar 25, 2024 · 7 comments · Fixed by #167, openedx/edx-platform#34657 or #169
Assignees

Comments

@feanil
Copy link
Contributor

feanil commented Mar 25, 2024

This repository is a depedency of edx-platform and needs to be upgraded to Python 3.11 before
the Readwood release is cut (mid-April).

  • Requirements are compiled with Python 3.8
  • Tests are run on Python 3.8 and 3.11
  • (Optional) Tests are also run with 3.12 and passing or 3.12 issues are ticketed.
  • Classifiers in setup.py setup.cfg or pyproject.toml indicate Python 3.11 support
  • A new version is release to PyPI
  • A PR is merged to edx-platform to use the new version
@kdmccormick
Copy link
Member

This ticket will handle upgrading codejail itself to 3.11. As a follow-up, we will need to upgrade edx-platform's codejail execution environment (a.k.a. edx-sandbox) to Python 3.11/3.12: openedx/edx-platform#34469

@ichintanjoshi
Copy link

assign me

@feanil
Copy link
Contributor Author

feanil commented Apr 16, 2024

I just took a look at the CI for this repo and it looks like it's quite complicated. I think in order to test on newer versions, we'll first have to add a new Dockerfile that is the same as the existing one but tests in python 3.11.

Then we'll have to update push-docker-image workflow to publish 2 images, one at latest and one at the 3.11 tag. Once that has landed, we should be able to run tests on the latest or the 3.8 image.

@MoisesGSalas
Copy link
Contributor

Hi @feanil, I would like to help on the 3.11 upgrade. If you are lacking on bandwidth I can take on this issue. Or if you need help somewhere else I can give a hand.

@feanil
Copy link
Contributor Author

feanil commented Apr 23, 2024

@MoisesGSalas I think this one is a bit complicated and I'm already working on it, but maybe you could take a look at openedx/credentials#2389 and suggest/make a further PR to get tests passing on Credentials.

@MoisesGSalas
Copy link
Contributor

I was focusing on this one because I was recently appointed as maintainer for the codejail repo, so I would really like to one something related to it to get more familiar (even if it's not this specific task).

I do have a bit of experience running codejail (mostly k8s) so I would like to hear any recommendation on where I can help. (I can still check the credentials one, but literally have 0 experience with that service).

@feanil feanil linked a pull request Apr 24, 2024 that will close this issue
@feanil
Copy link
Contributor Author

feanil commented Apr 24, 2024

Ah, gotcha, @MoisesGSalas take a look at #167 please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants