Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: adding python3.11 support. #2389

Merged
merged 1 commit into from
May 7, 2024
Merged

build: adding python3.11 support. #2389

merged 1 commit into from
May 7, 2024

Conversation

awais786
Copy link
Contributor

@awais786 awais786 commented Feb 19, 2024

on 3.11.9 they have made some changes which is breaking some tests. django will release its fix on 6th may.

Related PR
This is the root cause.

Upcoming fix.
django/django#17979 (comment)

Only coverage is failing.

@awais786 awais786 closed this Feb 23, 2024
@awais786 awais786 reopened this Mar 22, 2024
@awais786 awais786 changed the title build: adding python3.11 and 3.12 support. build: adding python3.11 support. Mar 22, 2024
# via
# -r requirements/dev.txt
# docker-compose
docker-compose==1.29.2
Copy link
Contributor Author

@awais786 awais786 Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to move this to some where else. This is not compatible with 3.11. Its main purpose is devstack.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requirement isn't needed anymore as there is no usage left of docker-compose v1 in this repo.

@@ -646,7 +601,7 @@ requests==2.31.0
# segment-analytics-python
# slumber
# social-auth-core
requests-oauthlib==1.4.0
requests-oauthlib==2.0.0
Copy link
Contributor Author

@awais786 awais786 Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is major upgrade. It requires thorough release notes review.

@feanil feanil linked an issue Apr 8, 2024 that may be closed by this pull request
@feanil
Copy link
Contributor

feanil commented Apr 8, 2024

@awais786 what's the status of this, are you still working on it?

@awais786
Copy link
Contributor Author

awais786 commented Apr 17, 2024

So failures are coming due to 3.11.9, on [3.11.7, 3.11.8] these tests are working fine. I am trying to findout the root cause.
python/cpython@f97f25e

I found the root cause. django/django#17979 (comment)

@awais786 awais786 force-pushed the python-support branch 2 times, most recently from 9d49d25 to d9af1b8 Compare April 17, 2024 18:05
@awais786
Copy link
Contributor Author

@feanil this seems valid issue.
django/django#17979 (comment)

@@ -9,11 +9,14 @@ on:
jobs:
quality_and_translations_tests:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.8", "3.11.8"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on 3.11.9 they have made some changes which is breaking some tests. django will release its fix on 6th may.

@awais786
Copy link
Contributor Author

Only coverage is failing due to some token issue.

@awais786 awais786 marked this pull request as ready for review April 25, 2024 13:41
@awais786 awais786 requested a review from a team as a code owner April 25, 2024 13:41
@deborahgu
Copy link
Member

Only coverage is failing due to some token issue.

we know about the coverage failures, so not worried about that. Is this ready for review and (if it passes review) merge, in your opinion, @awais786? Or should we wait for 3.11.9 fix?

@awais786
Copy link
Contributor Author

awais786 commented May 2, 2024

Only coverage is failing due to some token issue.

we know about the coverage failures, so not worried about that. Is this ready for review and (if it passes review) merge, in your opinion, @awais786? Or should we wait for 3.11.9 fix?

@deborahgu you can review this PR and merge if its look fine. We can update python version after 6th may once django version release.

@@ -11,14 +11,14 @@
# Common constraints for edx repos
-c common_constraints.txt

# The update to pyyaml 6.x failed as docker-compose wants <6,>=3.10. Pinning to <6.0. This constraint will be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it looks like we're not removing Python 3.8 support, will this break for Python 3.8?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this was more of an issue of incompatibility with an old version of docker-compose but that package is no longer needed.

Pyyaml 6.x is compatible with Python 3.8 and 3.11

@feanil
Copy link
Contributor

feanil commented May 6, 2024

@awais786 the Django update is out, can you re-base and re-build requirements?

@awais786
Copy link
Contributor Author

awais786 commented May 7, 2024

@awais786 the Django update is out, can you re-base and re-build requirements?

I tried yesterday but i have lost push rights. @iamsobanjaved is working on this now.

@deborahgu
Copy link
Member

I think I have permission to rebase and rebuild requirements, which I will do in a few minutes, since it's on me that I pulled in new requirements before grabbing this branch.

@deborahgu deborahgu merged commit 750e6c9 into master May 7, 2024
9 checks passed
@deborahgu deborahgu deleted the python-support branch May 7, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[credentials] Test Python 3.11
4 participants