-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: adding python3.11 support. #2389
Conversation
a938270
to
d02e2c0
Compare
77a45c9
to
abde806
Compare
075101f
to
d106847
Compare
# via | ||
# -r requirements/dev.txt | ||
# docker-compose | ||
docker-compose==1.29.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to move this to some where else. This is not compatible with 3.11
. Its main purpose is devstack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requirement isn't needed anymore as there is no usage left of docker-compose v1 in this repo.
requirements/all.txt
Outdated
@@ -646,7 +601,7 @@ requests==2.31.0 | |||
# segment-analytics-python | |||
# slumber | |||
# social-auth-core | |||
requests-oauthlib==1.4.0 | |||
requests-oauthlib==2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is major upgrade. It requires thorough release notes review.
@awais786 what's the status of this, are you still working on it? |
So failures are coming due to I found the root cause. django/django#17979 (comment) |
9d49d25
to
d9af1b8
Compare
@feanil this seems valid issue. |
.github/workflows/ci.yml
Outdated
@@ -9,11 +9,14 @@ on: | |||
jobs: | |||
quality_and_translations_tests: | |||
runs-on: ubuntu-latest | |||
strategy: | |||
matrix: | |||
python-version: ["3.8", "3.11.8"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on 3.11.9
they have made some changes which is breaking some tests. django will release its fix on 6th may.
Only coverage is failing due to some token issue. |
we know about the coverage failures, so not worried about that. Is this ready for review and (if it passes review) merge, in your opinion, @awais786? Or should we wait for 3.11.9 fix? |
@deborahgu you can review this PR and merge if its look fine. We can update python version after 6th may once django version release. |
@@ -11,14 +11,14 @@ | |||
# Common constraints for edx repos | |||
-c common_constraints.txt | |||
|
|||
# The update to pyyaml 6.x failed as docker-compose wants <6,>=3.10. Pinning to <6.0. This constraint will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since it looks like we're not removing Python 3.8 support, will this break for Python 3.8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this was more of an issue of incompatibility with an old version of docker-compose but that package is no longer needed.
Pyyaml 6.x is compatible with Python 3.8 and 3.11
@awais786 the Django update is out, can you re-base and re-build requirements? |
I tried yesterday but i have lost push rights. @iamsobanjaved is working on this now. |
afaf1f0
to
ba967f5
Compare
I think I have permission to rebase and rebuild requirements, which I will do in a few minutes, since it's on me that I pulled in new requirements before grabbing this branch. |
on 3.11.9 they have made some changes which is breaking some tests. django will release its fix on 6th may.
Related PR
This is the root cause.
Upcoming fix.
django/django#17979 (comment)
Only coverage is failing.