Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass AWS credentials correctly #168

Merged
merged 3 commits into from Dec 15, 2023

Conversation

ArturGaspar
Copy link
Contributor

Description

Fixes passing of AWS credentials, which are currently passed in inverse order.

Supporting information

https://discuss.openedx.org/t/bug-report-openedx-django-pyfs-uses-s3-access-key-id-and-secret-in-place-of-each-other/11874

Testing instructions

  1. Explicitly set 'aws_access_key_id' and 'aws_secret_access_key' in settings.DJFS.
  2. Test that objects in the bucket are accessible.

Deadline

None

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 14, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Dec 14, 2023

Thanks for the pull request, @ArturGaspar! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ArturGaspar ArturGaspar marked this pull request as ready for review December 14, 2023 15:04
@mphilbrick211 mphilbrick211 requested a review from a team December 14, 2023 22:06
@mphilbrick211
Copy link

Hi @openedx/2u-arch-bom! This is ready for review. Thanks!

@timmc-edx
Copy link

Looks about right. :-) Could you bump the version in djpyfs/__init__.py as well? A CHANGELOG.rst file would also be great. [template]

@timmc-edx timmc-edx self-requested a review December 15, 2023 09:55
@ArturGaspar ArturGaspar force-pushed the artur/aws-access-credentials-fix branch from 0145a04 to c05d43a Compare December 15, 2023 14:16
Copy link

@timmc-edx timmc-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@timmc-edx timmc-edx merged commit 89ca1ea into openedx:master Dec 15, 2023
6 checks passed
@openedx-webhooks
Copy link

@ArturGaspar 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@timmc-edx
Copy link

v3.4.1 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants