Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for specifying AWS region #169

Merged
merged 2 commits into from Feb 12, 2024

Conversation

ArturGaspar
Copy link
Contributor

Description

Support for specifying AWS region.

Testing instructions

  1. Set 'region' in settings.DJFS.
  2. Test that uploads to a bucket not in the default region work.
  3. Test that generated URLs contain the region name.

Other information

Private-ref: https://tasks.opencraft.com/browse/BB-8077

Also reset djpyfs.S3CONN so that it gets initialised again on each test instead
of being reused between tests, which is relevant as AWS region is one of its
options now and changes between test cases.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 15, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Dec 15, 2023

Thanks for the pull request, @ArturGaspar! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@viadanna
Copy link

Approved 👍

  • I tested this running on a sandbox with S3 region me-south-1
  • I read through the code
  • Includes documentation

@dianakhuang
Copy link
Contributor

This looks good code-wise, but I think if you want to use it, you're going to want to bump the version number.

@dianakhuang dianakhuang self-assigned this Feb 8, 2024
@ArturGaspar
Copy link
Contributor Author

@dianakhuang Done.

@dianakhuang dianakhuang merged commit ec3ece3 into openedx:master Feb 12, 2024
6 checks passed
@openedx-webhooks
Copy link

@ArturGaspar 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@dianakhuang
Copy link
Contributor

@ArturGaspar great! I merged it and created a new release with your changes: https://github.com/openedx/django-pyfs/releases/tag/v3.5.0 Should be up on PyPI soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants