New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for specifying AWS region #169
Conversation
Also reset djpyfs.S3CONN so that it gets initialised again on each test instead of being reused between tests, which is relevant as AWS region is one of its options now and changes between test cases.
Thanks for the pull request, @ArturGaspar! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Approved 👍
|
This looks good code-wise, but I think if you want to use it, you're going to want to bump the version number. |
@dianakhuang Done. |
@ArturGaspar 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
@ArturGaspar great! I merged it and created a new release with your changes: https://github.com/openedx/django-pyfs/releases/tag/v3.5.0 Should be up on PyPI soon. |
Description
Support for specifying AWS region.
Testing instructions
Other information
Private-ref: https://tasks.opencraft.com/browse/BB-8077