-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Palm Release Notes #321
Palm Release Notes #321
Conversation
Thanks for the pull request, @pdpinch! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hey Peter - I'm on PTO thru the 12th. I'll review promptly after. Thanks
for working on this!
…On Sun, Apr 30, 2023, 17:01 openedx-webhooks ***@***.***> wrote:
Thanks for the pull request, @pdpinch <https://github.com/pdpinch>!
Please note that it may take us up to several weeks or months to complete a
review and merge your PR.
Feel free to add as much of the following information to the ticket as you
can:
- supporting documentation
- Open edX discussion forum threads <https://discuss.openedx.org/>
- timeline information ("this must be merged by XX date", and why that
is)
- partner information ("this is a course on edx.org")
- any other information that can help Product understand the context
for the PR
All technical communication about the code itself will be done via the
GitHub pull request interface. As a reminder, our process documentation
is here
<http://edx-developer-guide.readthedocs.org/en/latest/process/overview.html>
.
Please let us know once your PR is ready for our review and all tests are
green.
—
Reply to this email directly, view it on GitHub
<#321 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPEWJNZ5TAHNCWL6Y3FC2TXD3HLTANCNFSM6AAAAAAXRE6MXM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
047ea1a
to
2ccf17a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far!
2ccf17a
to
ceb9ffe
Compare
Hi @pdpinch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
§ Stripe API changes LGTM. Thanks, @pdpinch.
* Tracking events have been added for reporting of threads, responses and comments, and for marking responses as endorsed. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmtcril I found these news events that were added going through the palm commits. Is this accurate? Is it complete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't aware of them, but I was speaking with @ayub02 about the existing events being maintained (they are). He might know more about the new events. We should document them here, too: https://docs.openedx.org/en/latest/developers/references/internal_data_formats/tracking_log_event_list.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! The new discussion related events can be found here. I'll be on vacation from 19th June till mid July and won't be able to update the docs, until after. Feel free to use the sheet to update the docs if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ayub02 I've taken an initial stab here, but I'm not super clear on the spreadsheet meanings or how up to date it is (looks like there are things in the actual columns which are not matching what's expected). I haven't gone through every tab, but it looks like at least the fields on search also changed?
Is the intention that what is in the "actual" column matches what's in the code right now for every event on every tab? I can take a more thorough pass if that's the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmtcril Correct. The "Actual" column is what's in the code (at least as per my testing). There are differences between actual and intended, but they don't need to be addressed on priority, in my opinion.
To turn on the New Learner home page, add and enable the :code:`learner_home_mfe.enabled` Waffle Flag in the django | ||
admin. To support a phased role out, there is also a setting :code:`LEARNER_HOME_MFE_REDIRECT_PERCENTAGE`. Set it to an | ||
integer value (0 - 100) representing what percentage of users should be redirected to Learner Home. 0 represents no | ||
rollout, 100 represents rollout to all users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest rewording this to point to the (hot-off-the-oven) experimental Tutor plugin installation instructions:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I replaced the instructions with your suggested link, and moved it up to the start of the section.
6bac726
to
b7661d1
Compare
@pdpinch 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
* Mongo is updated to v4.4. | ||
* Added a setting :code:`expiration_datetime_is_explicit` to the CourseMode model to override the default behavior of the Upgrade Deadline where it is set to be 10 days after the course start date. | ||
* Operators can now use a shared ElasticSearch installation for multiple OpenedX instances, using the setting :code:`ELASTIC_SEARCH_INDEX_PREFIX`. | ||
* the Micro-frontend (MFE) config setting `SUPPORT_URL` has been added to all MFEs. Use it to set the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pdpinch, this part seems to be missing some information.
Palm Release Notes.
closes openedx/wg-build-test-release#279
Date Needed (optional)
Palm will be released on June 12 2023
Reviewers
Possible roles follow. The PR submitter checks the boxes after each reviewer finishes and gives 👍.
fyi @blarghmatey @cachob @NotoriousMKD
Testing
HTML Version (optional)
Sandbox (optional)
Post-review