Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palm Release Notes #321

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Conversation

pdpinch
Copy link
Contributor

@pdpinch pdpinch commented Apr 30, 2023

Palm Release Notes.

closes openedx/wg-build-test-release#279

Date Needed (optional)

Palm will be released on June 12 2023

Reviewers

Possible roles follow. The PR submitter checks the boxes after each reviewer finishes and gives 👍.

fyi @blarghmatey @cachob @NotoriousMKD

Testing

  • Ran ./run_tests.sh without warnings or errors

HTML Version (optional)

Sandbox (optional)

Post-review

  • Squash commits

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 30, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 30, 2023

Thanks for the pull request, @pdpinch! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@sarina
Copy link
Contributor

sarina commented Apr 30, 2023 via email

@pdpinch pdpinch marked this pull request as draft May 1, 2023 00:58
@pdpinch pdpinch force-pushed the pdpinch/palm-release-notes branch from 047ea1a to 2ccf17a Compare May 9, 2023 21:12
Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far!

source/community/release_notes/palm.rst Outdated Show resolved Hide resolved
source/community/release_notes/palm.rst Outdated Show resolved Hide resolved
source/community/release_notes/palm.rst Outdated Show resolved Hide resolved
source/community/release_notes/palm.rst Show resolved Hide resolved
source/community/release_notes/palm.rst Outdated Show resolved Hide resolved
source/community/release_notes/palm.rst Outdated Show resolved Hide resolved
source/community/release_notes/palm.rst Outdated Show resolved Hide resolved
source/community/release_notes/palm.rst Outdated Show resolved Hide resolved
source/community/release_notes/palm.rst Show resolved Hide resolved
source/community/release_notes/palm.rst Outdated Show resolved Hide resolved
@UsamaSadiq
Copy link
Member

Hi @pdpinch
I have recently merged openedx-unsupported/devstack#1082 (Upgraded Mongo to 4.4 in devstack) in palm.master branch which is needed to be added in the palm release notes.

Copy link

@pshiu pshiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

§ Stripe API changes LGTM. Thanks, @pdpinch.

source/community/release_notes/palm.rst Outdated Show resolved Hide resolved
source/community/release_notes/palm.rst Outdated Show resolved Hide resolved
Comment on lines +249 to +241
* Tracking events have been added for reporting of threads, responses and comments, and for marking responses as endorsed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmtcril I found these news events that were added going through the palm commits. Is this accurate? Is it complete?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware of them, but I was speaking with @ayub02 about the existing events being maintained (they are). He might know more about the new events. We should document them here, too: https://docs.openedx.org/en/latest/developers/references/internal_data_formats/tracking_log_event_list.html

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! The new discussion related events can be found here. I'll be on vacation from 19th June till mid July and won't be able to update the docs, until after. Feel free to use the sheet to update the docs if you want.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ayub02 I've taken an initial stab here, but I'm not super clear on the spreadsheet meanings or how up to date it is (looks like there are things in the actual columns which are not matching what's expected). I haven't gone through every tab, but it looks like at least the fields on search also changed?

Is the intention that what is in the "actual" column matches what's in the code right now for every event on every tab? I can take a more thorough pass if that's the case.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmtcril Correct. The "Actual" column is what's in the code (at least as per my testing). There are differences between actual and intended, but they don't need to be addressed on priority, in my opinion.

To turn on the New Learner home page, add and enable the :code:`learner_home_mfe.enabled` Waffle Flag in the django
admin. To support a phased role out, there is also a setting :code:`LEARNER_HOME_MFE_REDIRECT_PERCENTAGE`. Set it to an
integer value (0 - 100) representing what percentage of users should be redirected to Learner Home. 0 represents no
rollout, 100 represents rollout to all users.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest rewording this to point to the (hot-off-the-oven) experimental Tutor plugin installation instructions:

https://github.com/openedx/openedx-tutor-plugins/tree/main/plugins/tutor-contrib-learner-dashboard-mfe#learner-dashboard-mfe-plugin-for-tutor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I replaced the instructions with your suggested link, and moved it up to the start of the section.

@sarina sarina merged commit 1dbee4f into openedx:main Jun 15, 2023
2 checks passed
@openedx-webhooks
Copy link

@pdpinch 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

* Mongo is updated to v4.4.
* Added a setting :code:`expiration_datetime_is_explicit` to the CourseMode model to override the default behavior of the Upgrade Deadline where it is set to be 10 days after the course start date.
* Operators can now use a shared ElasticSearch installation for multiple OpenedX instances, using the setting :code:`ELASTIC_SEARCH_INDEX_PREFIX`.
* the Micro-frontend (MFE) config setting `SUPPORT_URL` has been added to all MFEs. Use it to set the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pdpinch, this part seems to be missing some information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Palm Release Notes