Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add python 3.11 and 3.12 checks #254

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Danyal-Faheem
Copy link

@Danyal-Faheem Danyal-Faheem commented Apr 17, 2024

Changes

  • Added CI checks as part of the upgrade process to python 3.11 and python 3.12.
  • Also fixes one part of the downstream issue in tutor-ecommerce.
  • Updated docker-compose to docker compose.
  • Added a check on code coverage to only run for python 3.8 as we don't need to unnecessarily run it for every python verrsion.

⛔️ MAIN BRANCH WARNING! 2U EMPLOYEES must make branches against the 2u/main BRANCH

  • I have checked the branch to which I would like to merge.

⛔️ DEPRECATION WARNING

This repository is deprecated and in maintainence-only operation while we work on a replacement, please see this announcement for more information.

Although we have stopped integrating new contributions, we always appreciate security disclosures and patches sent to security@edx.org

If you're merging to master (not 2u/main) branch...

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • base.in if needed in production
    • test.in for test requirements
    • make upgrade && make requirements have been run to regenerate requirements
  • Version bumped

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub CI, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in ecommerce to upgrade dependencies (including ecommerce-worker)
    • This must be done after the version is visible in PyPi as make upgrade in ecommerce will look for the latest version in PyPi.
    • Note: the ecommerce-worker constraint in ecommerce must also be bumped to the latest version in PyPi.
  • Deploy ecommerce
  • Deploy ecomworker

@Danyal-Faheem Danyal-Faheem requested a review from a team as a code owner April 17, 2024 11:44
@DawoudSheraz
Copy link

@feanil Hi. Can you run the workflows on this PR, please? Thanks

Copy link

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi I run in a fork this PR and I have 2 comments:

  • The lint commit would fail because ci is not in the allowed words for commitlint. You can change it to test.
    image

  • I want to understand if the tests would run in python 3.11 and 3.12.
    Because In those tests the test_target shows 3.8
    2024-04-30_10-31

Also, I suspect in quality target tests are using the python3.8.
2024-04-30_10-47

I think the problem is that the quality env is in python3.12, but the tests are running in the edxops/ecomworker docker image and there is 3.8.

Also this line

docker exec ecomworker bash -c "sudo apt update -y; sudo apt install python3-dev -y;"

The python3-dev package seems installing with python3.8
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants