fix: fix

openedx · May 11, 2023 · 698a194 · 698a194
1 parent b8ac3e4
commit 698a194
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/ecommerce/bff/subscriptions/tests/test_subscription_views.py b/ecommerce/bff/subscriptions/tests/test_subscription_views.py
@@ -56,7 +56,7 @@ def test_with_skus(self, mock_embargo_check):
 
         response = self.client.post(url, data={'skus': [product1.stockrecords.first().partner_sku,
                                                         product2.stockrecords.first().partner_sku],
-                                               'ip_address': self.ip_address, 'user': self.user.username
+                                               'user_ip_address': self.ip_address, 'username': self.user.username
                                                })
 
         self.assertEqual(response.status_code, status.HTTP_200_OK)
@@ -138,6 +138,6 @@ def test_embargo_failure(self, mock_embargo_check):
                                                'user_ip_address': self.ip_address, 'username': self.user.username
                                                })
 
-        self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
-        expected_data = {'error': 'User blocked by embargo check'}
+        self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
+        expected_data = {'error': 'User blocked by embargo check', 'error_code': 'embargo_failed'}
         self.assertCountEqual(json.loads(response.content.decode('utf-8')), expected_data)
diff --git a/ecommerce/bff/subscriptions/views.py b/ecommerce/bff/subscriptions/views.py
@@ -43,8 +43,8 @@ def post(self, request, *args, **kwargs):
                         username
                     )
                     return Response({'error': 'User blocked by embargo check',
-                                     'error_message_id': 'embargo_failed'},
-                                    status=status.HTTP_403_FORBIDDEN)
+                                     'error_code': 'embargo_failed'},
+                                    status=status.HTTP_400_BAD_REQUEST)
 
             for product in available_products:
                 mode = self._mode_for_product(product)

diff --git a/ecommerce/extensions/payment/utils.py b/ecommerce/extensions/payment/utils.py
@@ -109,6 +109,7 @@ def embargo_check(user, site, products, ip=None):
     Returns:
         Bool
     """
+
     courses = []
     if not ip:
         _, _, ip = parse_tracking_context(user, usage='embargo')