Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 500 after applying coupon for Quince #4152

Conversation

DmytroAlipov
Copy link
Contributor

@DmytroAlipov DmytroAlipov commented Apr 9, 2024

This is a backport from the master (already merged).

Description

Steps to Reproduce:

  • Login by the user with staff rights
  • During purchase click on the link "Click here to purchase multiple seats in this course"
  • Confirm and pay
  • Activate the course with one of the coupons sent to your email
  • Open /dashboard page
dashboard

The issue was that the date-time also included milliseconds, which is not acceptable for converting the date and time into the required format.

ValueError: time data '2033-06-25T11:40:12.267999Z' does not match format '%Y-%m-%dT%H:%M:%SZ'

@DmytroAlipov DmytroAlipov requested a review from a team as a code owner April 9, 2024 10:32
@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 9, 2024
@DmytroAlipov DmytroAlipov added the backport PR backports a change from main to a named release. label Apr 9, 2024
Copy link
Contributor

@cmltaWt0 cmltaWt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the fix on a test Env.
Merging.

@cmltaWt0 cmltaWt0 merged commit 7fa62f7 into openedx:open-release/quince.master Apr 9, 2024
4 checks passed
@openedx-webhooks
Copy link

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the fix-500-after-applying-coupon-quince branch April 9, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants