Merge pull request #1336 from openedx/bilalqamar95/workflow-dependanc…

…y-update Use 'npm ci' instead of 'npm install'
openedx-unsupported · Jul 18, 2022 · 0b31888 · 0b31888
2 parents 1083ac1 + b3c7871
commit 0b31888
Show file tree

Hide file tree

Showing 4 changed files with 379 additions and 93 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -33,8 +33,6 @@ jobs:
           source /edx/app/analytics_api/venvs/analytics_api/bin/activate &&
           pip install setuptools==49.6.0 &&
           make -C /edx/app/analytics_api/analytics_api github_ci"
-      - name: clean package-lock.json
-        run: rm package-lock.json
       - name: install dependencies
         run: pip install -r requirements/github.txt
       - name: test quality

diff --git a/Makefile b/Makefile
@@ -34,7 +34,7 @@ requirements.py: piptools
 	pip-sync -q requirements/base.txt
 
 requirements.js:
-	npm install --unsafe-perm
+	npm ci --unsafe-perm
 
 test.requirements: piptools
 	pip-sync -q requirements/test.txt