Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Switch to Clinton's fork of django-waffle #693

Closed
wants to merge 2 commits into from

Conversation

thallada
Copy link
Contributor

Switching to @clintonb's fork of django-waffle, which has an open pull request against the main repo. Clinton's fork is more well-tested than the other fork we were on.

Hopefully this is only temporary and once the status of django-waffle is figured out, we can go back to installing from pip.

@edx/educator-dahlia

Push the edxops/insights:waffle-fork image to edxops/insights:latest and then
revert this commit before merging the PR.
Copy link
Contributor

@clintonb clintonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will not guarantee my fork will exist for any period of time after my PR is merged (if it's ever merged!). Please fork this to edX. In general, anytime we need to pull from GitHub, we should be pulling from either the official repo or an edX repo.

@codecov-io
Copy link

Codecov Report

Merging #693 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #693   +/-   ##
======================================
  Coverage    94.2%   94.2%           
======================================
  Files         184     184           
  Lines        9381    9381           
  Branches      742     742           
======================================
  Hits         8837    8837           
  Misses        380     380           
  Partials      164     164

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d31c5f5...f1962d1. Read the comment docs.

@thallada
Copy link
Contributor Author

We should switch to django-waffle version 0.12.0 from pip instead now that Clinton has become a maintainer and merged his PR (see jazzband/django-waffle#246)

@thallada thallada closed this Jun 28, 2017
@thallada thallada deleted the thallada/waffle-fork branch June 28, 2017 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants