MA-3186 : Upgrade to Android Studio 2.3

[miankhalid]

Description

MA-3186

• Gradle version bumped from 2.1.2 to 2.3.0
• Gradle distribution version bumped from 2.14.1 to 3.3
• Groovy version bumped from 2.4.4 to 2.4.7
• Build tools version bumped from 23.0.3 to 25.0.2
• Segment version bumped from 3.4.0 to 4.2.6

[laibinzhi]

@miankhalid Can you run edx at AS2.3?

[miankhalid]

@miankhalid Can you run edx at AS2.3?

Yep, if you want to run AS 2.3, you'll need to checkout this PR or keep the changes in this PR in whatever branch you are working.

[kdmccormick]

Hey @miankhalid, do you know if there are any plans to try to get this merged soon?

[miankhalid]

@kdmccormick we will be merging this in the first part of our next sprint! yay!

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@f509d13). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master     #938   +/-   ##
=========================================
  Coverage          ?   16.81%           
  Complexity        ?     1023           
=========================================
  Files             ?      477           
  Lines             ?    20405           
  Branches          ?     2348           
=========================================
  Hits              ?     3432           
  Misses            ?    16580           
  Partials          ?      393

Impacted Files	Coverage Δ	Complexity Δ
.../java/org/edx/mobile/view/custom/EdxRatingBar.java	0% <ø> (ø)	0 <0> (?)
...in/java/org/edx/mobile/util/images/ShareUtils.java	15.15% <ø> (ø)	2 <0> (?)
...e/registration/view/RegistrationOptionSpinner.java	0% <ø> (ø)	0 <0> (?)
.../java/org/edx/mobile/view/custom/TitleRowView.java	0% <0%> (ø)	0 <0> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f509d13...9f204f8. Read the comment docs.

[miankhalid]

Ready for review @farhan.

[farhan]

I am getting following error when i try to make build with any build variant. Ideally our gradle should make build with android's debug.keystore for our non-release builds.

Error:Execution failed for task ':OpenEdXMobile:validateSigningDevRelease'.

Keystore file /Users/farhankhan/MyStuff/ArbisoftProjects/Edx/edx-app-android/OpenEdXMobile/edx-android-release-key.keystore not found for signing config 'releasekey'.

Last resort:
If this couldn't happen we can place android's debug keystore in our project which solve the problem in my case.

[farhan]

LGTM 👍 , just one build issue.

[miankhalid]

@farhan issue fixed. Another pass maybe ?

[farhan]

@miankhalid tried with fresh clone, still getting same issue.

[miankhalid]

Try this solution @farhan: #976.

[farhan]

@miankhalid two improvements could be done in this solution.

• In step 2, we can simple ask to clean project from "Build -> Clean Project" menu options.
• Update step 3 to "Refresh all Gradle projects in "Gradle" tool windows."

[miankhalid]

@farhan I just checked if we skip Step # 2 and just follow Steps 1 & 3, the build works just fine without any errors. Lemme update the Issue #976.

[farhan]

LGTM 👍