Skip to content

Commit

Permalink
Merge pull request #250 from edx/christina/pr-process
Browse files Browse the repository at this point in the history
Remove note about optional tags on review comments.
  • Loading branch information
Christina Roberts committed Apr 1, 2015
2 parents 5924e86 + 390fa2a commit 479ce60
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions en_us/developers/source/process/core-committer.rst
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ working on, and so on.
Review Comments Terminology
---------------------------
In order to expedite the review process and to have a clear and mutual understanding
between reviewers and contributors, the following terminology is strongly suggested
between reviewers and contributors, the following terminology should be used
when submitting comments on a PR:

* **Must** - A comment of type "Must" indicates the reviewer feels strongly about
Expand All @@ -85,9 +85,6 @@ As an example, the following PR comment is clearly categorized as Optional:
``"Optional: Consider reducing the high degree of connascense in this code by using
keyword arguments."``

**Note:** Unless stated or implied otherwise, all comments are assumed to be of type
"Must".

**Note 2:** It is possible that after further discussion and review, the reviewer
**Note:** It is possible that after further discussion and review, the reviewer
chooses to amend their comment, thereby changing its severity to be higher or
lower than what was originally set.

0 comments on commit 479ce60

Please sign in to comment.