feat: replace pyjwkest with pyjwt #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumarkhan999
force-pushed
the
umar/replace-jwkest-with-pyjwt
branch
4 times, most recently
from
43ff502
to
70f2003
Compare
This was referenced Mar 16, 2023
mumarkhan999
force-pushed
the
umar/replace-jwkest-with-pyjwt
branch
from
70f2003
to
f819431
Compare
mumarkhan999
changed the title
timmc-edx
reviewed
Mar 17, 2023
mumarkhan999
force-pushed
the
umar/replace-jwkest-with-pyjwt
branch
from
f819431
to
cf402f5
Compare
timmc-edx
reviewed
Mar 20, 2023
timmc-edx
reviewed
Mar 21, 2023
mumarkhan999
force-pushed
the
umar/replace-jwkest-with-pyjwt
branch
2 times, most recently
from
40d63b8
to
7750a04
Compare
mumarkhan999
force-pushed
the
umar/replace-jwkest-with-pyjwt
branch
from
09f0927
to
46e21b4
Compare
|
Could you change the commit and PR commit type to |
timmc-edx
reviewed
Apr 26, 2023
timmc-edx
reviewed
Apr 26, 2023
timmc-edx
added a commit
that referenced
this pull request
Apr 26, 2023
This would be my suggestion for how to handle the existing test settings in <#311>. - Using a multiline string rather than a collection of strings allows developers to copy and paste the JSON freely, without having to splice it back together. - Run the `JWT_PRIVATE_SIGNING_JWK` through the new `jwk-precompute-params.py` script in edx-platform. Keeping the original keypair (but upgrading the signing key) allows the diff to show exactly what has changed. Deployers will be upgrading their own production keys, so it's best to have this match their upgrade process from Palm to Quince as closely as possible.
timmc-edx
added a commit
that referenced
this pull request
Apr 26, 2023
This would be my suggestion for how to handle the existing test settings in <#311>. - Using a multiline string rather than a collection of strings allows developers to copy and paste the JSON freely, without having to splice it back together. - Run the `JWT_PRIVATE_SIGNING_JWK` through the new `jwk-precompute-params.py` script in edx-platform. Note that the `p` and `q` parameters switch place. This should be harmless -- I believe those are the two original primes in the RSA key, and it doesn't matter which is which. Keeping the original keypair (but upgrading the signing key) allows the diff to show exactly what has changed. Deployers will be upgrading their own production keys, so it's best to have this match their upgrade process from Palm to Quince as closely as possible.
mumarkhan999
force-pushed
the
umar/replace-jwkest-with-pyjwt
branch
3 times, most recently
from
3aa3806
to
40d971d
Compare
mumarkhan999
changed the title
mumarkhan999
force-pushed
the
umar/replace-jwkest-with-pyjwt
branch
from
40d971d
to
f87bfd6
Compare
timmc-edx
reviewed
May 10, 2023
|
|
||
| if add_symmetric_keys: | ||
| # symmetric key | ||
| key_set.add({'key': jwt_issuer['SECRET_KEY'], 'kty': 'oct'}) | ||
| # symmetric_key |
There was a problem hiding this comment.
[nit] Looks like an accidental change here of a space to an underscore.
timmc-edx
approved these changes
May 10, 2023
mumarkhan999
force-pushed
the
umar/replace-jwkest-with-pyjwt
branch
from
f87bfd6
to
fab29c5
Compare
timmc-edx
approved these changes
May 15, 2023
mumarkhan999
force-pushed
the
umar/replace-jwkest-with-pyjwt
branch
from
fab29c5
to
676126e
Compare
mumarkhan999
force-pushed
the
umar/replace-jwkest-with-pyjwt
branch
from
676126e
to
f50a9a7
Compare
|
Looks like you dropped the 8.8.0 version bump again. I'll add that in a new PR and do a release. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we're removing
pyjwkestfrom our dependencies, this PR is in the continuation of that task.In this PR the
JWKprivate-public keypair has been updated as the new packagePyJWTwhich we're using instead ofPyjwkestis not compatible with the older ones.Similar PRs
Another ticket
Slack thread [Private]
Tool used for JWK keypair creation
Previous attempts