Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add JWT key-set size custom attribute to aid in key rotations #317

Merged
merged 2 commits into from
Apr 5, 2023
Merged

feat: Add JWT key-set size custom attribute to aid in key rotations #317

merged 2 commits into from
Apr 5, 2023

Conversation

timmc-edx
Copy link
Contributor

Part of edx/edx-arch-experiments#261

Merge checklist:

  • Version bump if needed
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

rgraber
rgraber suggested changes Apr 5, 2023
View reviewed changes
Copy link

@rgraber rgraber left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the

# .. custom_attribute_name: 
# .. custom_attribute_description:

format for the description

@timmc-edx
Copy link
Contributor Author

Oh, yes! I'd forgotten about that, thank you.

rgraber
rgraber approved these changes Apr 5, 2023
View reviewed changes
Copy link

@rgraber rgraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmc-edx timmc-edx merged commit 6049067 into master Apr 5, 2023
7 checks passed
@timmc-edx timmc-edx deleted the timmc/keys-size branch April 5, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgraber rgraber rgraber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timmc-edx @rgraber