feat: block team ORAs from ESG (for now) #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/esg-demo-mode #1849 +/- ##
========================================================
Coverage ? 94.99%
========================================================
Files ? 153
Lines ? 17246
Branches ? 1896
========================================================
Hits ? 16383
Misses ? 647
Partials ? 216
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
jansenk
requested review from
jnlapierre,
leangseu-edx,
mattcarter,
muselesscreator,
nsprenkle and
a team
leangseu-edx
approved these changes
Apr 19, 2022
mattcarter
pushed a commit
that referenced
this pull request
Apr 19, 2022
* feat: block team ORAs from ESG (for now) * style: quality * test: test * chore: static * chore: version
mattcarter
added a commit
that referenced
this pull request
Apr 19, 2022
* feat: stuff column should not be clickable on ESG enable test: update unit testing chore: update static chore: update translations chore: version bump * feat: add link from xblock staff area to ESG (#1839) Added a link to ESG demo when ESG is not enabled. Made the staff area buttons inline-block with a margin because they are now overflowing. I tried to mimic a Paragon Button in terms of coloring: used primary-500 for background, darkened by 7.5% on hover. * feat: block team ORAs from ESG (for now) (#1849) * feat: block team ORAs from ESG (for now) * style: quality * test: test * chore: static * chore: version * chore: Update version * chore: Update translations * chore: translations * chore: js versions Co-authored-by: Leangseu Kim <lkim@edx.org> Co-authored-by: Jansen Kantor <jkantor@edx.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR - block team ORAs from ESG (for now)
JIRA:AU-617 (Not exactly FOR this ticket, but relates to)
What changed?
Developer Checklist
Testing Instructions
In a course with both Team and Individual ORAs visit the Instructor Dashboard ORA page with the ESG enabled flag on and off. Click into the ORAs to see staff area.
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora
Screenshots:
Instructor Dashboard (ESG Enabled)
Instructor Dashboard (ESG Disabled)
Team ORA Staff Area(ESG Enabled)
Team ORA Staff Area (ESG Disabled)
Staff ORA Staff Area (ESG Enabled) [Existing Behavior]
Staff ORA Staff Area (ESG Disabled) [Existing Behavior]