[DEPR]: legacy_ip code and Waffle switch #33733
Labels
depr
Proposal for deprecation & removal per OEP-21
Comments
timmc-edx
added a commit
that referenced
this issue
Nov 16, 2023
This switch has been kept disabled in edx.org for well over a year with no trouble. DEPR issue: #33733
2 tasks
|
This is marked as Blocked until the required time period has elapsed (12/1) |
timmc-edx
added a commit
that referenced
this issue
Dec 1, 2023
This switch has been kept disabled in edx.org for well over a year with no trouble, and the migration to `CLOSEST_CLIENT_IP_FROM_HEADERS` was introduced in Nutmeg. DEPR issue: #33733
|
Removal has been completed. |
irtazaakram
pushed a commit
that referenced
this issue
Dec 4, 2023
This switch has been kept disabled in edx.org for well over a year with no trouble, and the migration to `CLOSEST_CLIENT_IP_FROM_HEADERS` was introduced in Nutmeg. DEPR issue: #33733
fazledyn-or
pushed a commit
to fazledyn-or/edx-platform
that referenced
this issue
Dec 18, 2023
This switch has been kept disabled in edx.org for well over a year with no trouble, and the migration to `CLOSEST_CLIENT_IP_FROM_HEADERS` was introduced in Nutmeg. DEPR issue: openedx#33733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Proposal Date
2023-11-16
Target Ticket Acceptance Date
2023-12-01
Earliest Open edX Named Release Without This Functionality
Redwood - 2024-04
Rationale
The code in
openedx.core.djangoapps.util.legacy_ipalways uses the leftmost IP address in theX-Forwarded-Forheader, which is insecure. The code inedx_django_utils.ipoffers a safer alternative.For an explanation of the details, see the
edx_django_utils.ipdunder-init documentation: https://github.com/openedx/edx-django-utils/blob/master/edx_django_utils/ip/__init__.pyRemoval
This would entail removing openedx/core/djangoapps/util/legacy_ip.py, containing a small bit of X-Forwarded-For parsing and the Waffle switch
ip.legacythat is supposed to control its use.The remaining references are all conditional statements that use the Waffle switch to determine whether to use the old code.
Replacement
All of the references to legacy_ip are guarded by conditionals and already default to a call to the replacement
edx_django_utils.ipcode.This PR should effect the replacement: #33735
Deprecation
No response
Migration
No response
Additional Info
No response
Discourse topic: https://discuss.openedx.org/t/deprecation-removal-legacy-ip-code-and-waffle-switch-edx-platform-33733/11718
The text was updated successfully, but these errors were encountered: