Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SE-4304] feat: add celery beat configuration to Koa #28148

Conversation

gabor-boros
Copy link
Contributor

@gabor-boros gabor-boros commented Jul 12, 2021

This Pull Request adds CELERYBEAT_SCHEDULER to the edx-platform and sets it to its default value defined by Celery documentation.

The configuration repository PR: https://github.com/edx/configuration/pull/6407

Settings

ADDL_INSTALLED_APPS:
- django_celery_beat

EDXAPP_ENABLE_CELERY_BEAT: true
SANDBOX_ENABLE_REDIS: true
EDXAPP_CELERY_BROKER_TRANSPORT: 'redis'
EDXAPP_CELERY_BROKER_HOSTNAME: '127.0.0.1:6379'
EDXAPP_CELERY_BROKER_USE_SSL: false
EDXAPP_CELERY_BROKER_VHOST: '/0'
EDXAPP_CELERY_USER: 'default'
EDXAPP_CELERY_PASSWORD: ''
EDXAPP_CELERYBEAT_SCHEDULER: django_celery_beat.schedulers:DatabaseScheduler

Dependencies:

Sandbox URL: https://pr28148.sandbox.opencraft.hosting/

Merge deadline: ASAP

Testing instructions:

  • Login using the edX user
  • Navigate to the Instructor dashboard's download tab
  • Click on Download profile information as a CSV
  • Scroll down to the bottom of the page and wait some seconds
  • Validate that the generated report appears and downloadable

Author notes and concerns:

The configuration changes are already merged

Reviewers

  • (OpenCraft internal reviewer's GitHub username goes here)
  • edX reviewer[s] TBD

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Jul 12, 2021
@openedx-webhooks
Copy link

Thanks for the pull request, @gabor-boros! I've created OSPR-5913 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@natabene
Copy link
Contributor

@gabor-boros Thank you for your contribution. Is this ready for our review?

@itsjeyd
Copy link
Contributor

itsjeyd commented Jul 12, 2021

Related edx-platform PRs, for reference:

@gabor-boros
Copy link
Contributor Author

@natabene yes, this is ready for review, thank you!

@arbrandes
Copy link
Contributor

This is in Maple and Lilac, so it makes sense to add it to Koa, too. Merging.

@arbrandes arbrandes merged commit 7a12578 into openedx:open-release/koa.master Oct 27, 2021
@openedx-webhooks
Copy link

@gabor-boros 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@gabor-boros gabor-boros deleted the gabor/backport-celery-updates-koa branch October 28, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants