New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: external plugin integration in instructor dashboard #29376
feat: external plugin integration in instructor dashboard #29376
Conversation
Thanks for the pull request, @MAbdurrehman12! I've created OSPR-6232 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
9d3768a
to
f001232
Compare
a7c8f83
to
85ad46c
Compare
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
e5d2f47
to
87f86ce
Compare
@natabene Can I review this PR? |
bc655bf
to
25748eb
Compare
@MAbdurrehman12 Thank you for your contribution. @ziafazal Thanks for offering, let me check with the owning team. I will post an update here. |
@ziafazal Please review. |
@MAbdurrehman12 Could you please add unit test to support you changes in instructor dashboard view? |
Sure. I'll add it |
25748eb
to
5bc4d4d
Compare
55de451
to
90c74f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@MAbdurrehman12 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Your PR has finished running tests. There were no failures. |
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
EdX Release Notice: This PR has been deployed to the production environment. |
Description
There are plugins which return context which is then embedded/used accordingly. So in instructor dashboard we need a flow/function which get/fetches the context from external plugins and updates the existing context with the context returned from external plugins. This has been done via a function get_plugins_view_context of edx_django_utils.plugins. A separate constant file has been created in instructor which consist of a constant: INSTRUCTOR_DASHBOARD_PLUGIN_VIEW_NAME. Any external plugin which uses this constant, will return context to instructor dashboard.
While installing an external plugin, all the settings should be derived first and add_plugins function should be called afterwards in lms -> envs -> production.py but currently add_plugins function is being called before derive_settings function, hence their order has been switched. Same goes for cms -> envs -> production.py
In lms/templates/instructor/instructor_dashboard_2/instructor_dashboard_2.html, we include the html files of sections from relative path, but in case of plugin, we need to give absolute path, as plugin's html file is inside plugin so in order to give absolute path we need to add a prefix "/".
Supporting information
None
Testing instructions
Deadline
None
Other information
None