fix: give proper status code for invalid sequence metadata requests #29741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the sequence metadata view is asked to give metadata for a block that is not a sequence (or section), give a proper http code back, rather than throwing an attribute exception. This avoids a monitoring error being flagged, and lets the frontend catch this case specially (which the MFE does do, to notice that it actually has a unit, not a sequence).
asadiqbal08
force-pushed
the
asadiqbal08/backport-learning-mfe-error-fixx
branch
from
59c001b
to
1faf355
Compare
|
Thanks for the pull request, @asadiqbal08! I've created OSPR-6384 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
needs triage
open-source-contribution
|
@asadiqbal08 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
@asadiqbal08 Thank you for your contribution,. |
pdpinch
added a commit
to mitodl/edx-platform
that referenced
this pull request
Jan 14, 2022
…equests (openedx#29741)" This reverts commit a76a79f. it was a backport of openedx#29741 but it was breaking unit tests
regisb
added a commit
to overhangio/tutor
that referenced
this pull request
Feb 1, 2022
regisb
added a commit
to overhangio/tutor
that referenced
this pull request
Feb 1, 2022
regisb
added a commit
to overhangio/tutor
that referenced
this pull request
Feb 1, 2022
mshukurlu
pushed a commit
to mshukurlu/edx-platform
that referenced
this pull request
Feb 9, 2022
…penedx#29741) If the sequence metadata view is asked to give metadata for a block that is not a sequence (or section), give a proper http code back, rather than throwing an attribute exception. This avoids a monitoring error being flagged, and lets the frontend catch this case specially (which the MFE does do, to notice that it actually has a unit, not a sequence). Co-authored-by: Michael Terry <mterry@edx.org>
ztraboo
pushed a commit
to CUCWD/edx-platform
that referenced
this pull request
May 27, 2022
…penedx#29741) If the sequence metadata view is asked to give metadata for a block that is not a sequence (or section), give a proper http code back, rather than throwing an attribute exception. This avoids a monitoring error being flagged, and lets the frontend catch this case specially (which the MFE does do, to notice that it actually has a unit, not a sequence). Co-authored-by: Michael Terry <mterry@edx.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the sequence metadata view is asked to give metadata for a block
that is not a sequence (or section), give a proper http code back,
rather than throwing an attribute exception.
This avoids a monitoring error being flagged, and lets the frontend
catch this case specially (which the MFE does do, to notice that it
actually has a unit, not a sequence).
Description
After running Maple in production for a couple weeks, we began seeing errors link this in our logs:
It seems to be associated with students experiencing timeouts when clicking the middle item in the Learner MFE breadcrumbs (the sequential).
Demo: 'VerticalBlockWithMixins' object has no attribute 'get_metadata'
Supporting information
fixes: openedx/wg-build-test-release#129
Contain the changes of edx/edx-platform@7123807