Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FC-0001: Account pages -> micro-frontend #30336

Merged
merged 7 commits into from
Mar 7, 2023
Merged

FC-0001: Account pages -> micro-frontend #30336

merged 7 commits into from
Mar 7, 2023

Conversation

UvgenGen
Copy link
Contributor

@UvgenGen UvgenGen commented May 2, 2022 •
edited

Merge after the Olive release.

Description

replaced edx-platform's older implementation of the Django-server-side rendering of the following pages with new micro-frontend-based implementations:

PR to frontend-platform: openedx/frontend-platform#326
PR to frontend-component-header: openedx/frontend-component-header#210

Supporting information

openedx/public-engineering#71
Original Jira Issue: https://openedx.atlassian.net/browse/DEPR-17

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels May 2, 2022
@openedx-webhooks
Copy link

openedx-webhooks commented May 2, 2022 •
edited

Thanks for the pull request, @UvgenGen! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

This was referenced May 2, 2022
Merged
Merged
@natabene
Copy link
Contributor

natabene commented May 3, 2022

@dianakhuang This seems to be with arch-bom, do you mind reviewing and merging?

@abdullahwaheed
Copy link
Contributor

@UvgenGen i have reviewed and tested your changes and resolved merge conflicts locally. I cannot push my changes in your forked repo. Please either give me write access to your repo or i'll provide the patch file for changes.

@UvgenGen
Copy link
Contributor Author

@abdullahwaheed Could you provide the patch file please?

@abdullahwaheed
Copy link
Contributor

@UvgenGen the patch couldn't created for all the commits as i have merged it with master and resolved conflicts only. Could you please rebase it with master and i'll help you resolve the conflicts

@UvgenGen
Copy link
Contributor Author

@abdullahwaheed yes, sure. I rebased this PR and resolved conflicts. Files affected: lms/djangoapps/discussion/views.py and common/djangoapps/Third_Party_auth/tests/specs/base.py.

@arbrandes arbrandes linked an issue Oct 18, 2022 that may be closed by this pull request
[DEPR]: Account pages -> micro-frontend openedx/public-engineering#71
Open
abdullahwaheed
abdullahwaheed approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@abdullahwaheed abdullahwaheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with respective changes. LGTM

@abdullahwaheed
Copy link
Contributor

@UvgenGen could you please rebase it again

@UvgenGen
Copy link
Contributor Author

@abdullahwaheed PR rebased)

@e0d
Copy link
Contributor

e0d commented Jan 20, 2023

@UvgenGen should the name of this PR be updated? We're after olive, can this now be merged?

@UvgenGen
Copy link
Contributor Author

@e0d I removed Note: don't merge in description, did I understand you correctly?. Yes, I think nothing prevents merge it now)

@e0d
Copy link
Contributor

e0d commented Jan 20, 2023

@dianakhuang is this good to merge now?
@arbrandes FYI as MFE guru and Olive release lead.

arbrandes
arbrandes approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@dianakhuang
Copy link
Contributor

I will try to get it on FED-BOM's agenda to review and help get this merged. Very excited for this to land!

@abdullahwaheed
Copy link
Contributor

@UvgenGen need rebasing again due to frequent changes in platform :)
or you can give me write access to your forked repo so i can update changes.

@UvgenGen
Copy link
Contributor Author

@abdullahwaheed PR rebased)

@mphilbrick211
Copy link

mphilbrick211 commented Feb 24, 2023 •
edited

Hi @UvgenGen @arbrandes @dianakhuang - is this good to merge once the branch conflicts are resolved?

@UvgenGen
Copy link
Contributor Author

UvgenGen commented Mar 3, 2023

@mphilbrick211 PR rebased, conflicts resolved)

@mphilbrick211
Copy link

@arbrandes @dianakhuang Would one of you be able to merge this?

@abdullahwaheed abdullahwaheed merged commit 0f02c7b into openedx:master Mar 7, 2023
@openedx-webhooks
Copy link

@UvgenGen 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

abdullahwaheed added a commit that referenced this pull request Mar 7, 2023
@abdullahwaheed
Revert "FC-0001: Account pages -> micro-frontend (#30336)"
20ad5fa 
This reverts commit 0f02c7b.
@abdullahwaheed abdullahwaheed mentioned this pull request Mar 7, 2023
Merged
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

dianakhuang pushed a commit that referenced this pull request Mar 7, 2023
@abdullahwaheed @dianakhuang
Revert "FC-0001: Account pages -> micro-frontend (#30336)"
0573b1e 
This reverts commit 0f02c7b.
rgraber pushed a commit that referenced this pull request Mar 7, 2023
@abdullahwaheed
Revert "FC-0001: Account pages -> micro-frontend (#30336)" (#31888)
90c4ca6 
This reverts commit 0f02c7b.
abdullahwaheed added a commit that referenced this pull request Mar 8, 2023
@abdullahwaheed
Revert "Revert "FC-0001: Account pages -> micro-frontend (#30336)" (#…
13c8503 
…31888)"

This reverts commit 90c4ca6.
@dianakhuang dianakhuang mentioned this pull request Mar 8, 2023
Closed
@abdullahwaheed abdullahwaheed mentioned this pull request Oct 18, 2023
Merged
abdullahwaheed added a commit that referenced this pull request Oct 19, 2023
@abdullahwaheed @BilalQamar95
feat: Account and profile MFE legacy removal - redeployment (#31893)
08f5e7e 
feat: Account and profile MFE legacy removal - redeployment

* Revert "Revert "FC-0001: Account pages -> micro-frontend (#30336)" (#31888)"

This reverts commit 90c4ca6.

* refactor: removed filters test from user_api accounts

---------

Co-authored-by: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbrandes arbrandes arbrandes approved these changes

@abdullahwaheed abdullahwaheed abdullahwaheed approved these changes

@BilalQamar95 BilalQamar95 BilalQamar95 approved these changes

@ishahroz ishahroz ishahroz approved these changes

Assignees

@dianakhuang dianakhuang

Labels
FC Funded Contributions open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DEPR]: Account pages -> micro-frontend