Removed paver code and scripts specific to unit testing #31180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zubairshakoorarbisoft could you please expand the PR description with a little more details about the reason for this change? |
|
@bradenmacdonald Its kind of draft PR, currently working on it. The reason is to remove
paver code (only tests specific) is that now we are are running test using
pytest that's why need to remove this useless codebase from this repo.
To get the more context on this task, please have a look into this issue #31168
CC: @iamsobanjaved
…On Fri, 21 Oct 2022 at 11:53 PM, Braden MacDonald ***@***.***> wrote:
@zubairshakoorarbisoft <https://github.com/zubairshakoorarbisoft> could
you please expand the PR description with a little more details about the
reason for this change?
And please remove the template text like "Useful information to include:"
and "Please provide detailed step-by-step instructions for testing this
change." if you are not using it.
—
Reply to this email directly, view it on GitHub
<#31180 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANX4P4VZFJE25D3S2JNMCSLWELRBJANCNFSM6AAAAAARJ5ZM7M>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
The content of this email and attachment(s) are confidential and intended
solely for the recipient(s) specified in the message. If you received this
email by error, please alert the sender by replying to this email and
follow with its deletion, so that we can ensure such an error does not
occur in future. If you are not the intended recipient, you are strictly
prohibited to use, copy, disseminate or store this email or its
attachment(s).
|
zubairshakoorarbisoft
force-pushed
the
zshkoor/paver-code-removal
branch
4 times, most recently
from
64b45c0
to
4faebca
Compare
iamsobanjaved
approved these changes
Dec 19, 2022
| ("compare-branch=", "b", "Branch to compare against, defaults to origin/master"), | ||
| ], share_with=['coverage']) | ||
| @timed | ||
| def diff_coverage(options): |
There was a problem hiding this comment.
It is being used currently by JS tests so moved this command to this file
zubairshakoorarbisoft
changed the title
UsamaSadiq
requested changes
Jan 4, 2023
There was a problem hiding this comment.
Looks good overall but need a few more changes to be merged:
- Update the script paver_autocomplete to remove unnecessary references or the script altogether.
- Update the PR description with a details description & summary of why these changes are being made.
iamsobanjaved
force-pushed
the
zshkoor/paver-code-removal
branch
from
bb84fb2
to
1c9c2ce
Compare
UsamaSadiq
approved these changes
Jan 16, 2023
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
kdmccormick
added a commit
that referenced
this pull request
Feb 20, 2023
The contents of this file were deleted by #31180; this commit just deletes the leftover empty file.
kdmccormick
added a commit
that referenced
this pull request
Apr 18, 2023
The contents of this file were deleted by #31180; this commit just deletes the leftover empty file.
kdmccormick
added a commit
to kdmccormick/edx-platform
that referenced
this pull request
May 11, 2023
The contents of this file were deleted by openedx#31180; this commit just deletes the leftover empty file.
kdmccormick
added a commit
that referenced
this pull request
May 11, 2023
The contents of this file were deleted by #31180; this commit just deletes the leftover empty file.
JuanDavidBuitrago
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
May 25, 2023
The contents of this file were deleted by openedx#31180; this commit just deletes the leftover empty file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the codebase specific for python unit testing in the paver. We have moved to use pytest directly for python unit testing so now removing all obsolete code.