feat!: Remove block_structure.raise_error_when_not_found waffle flag. #31633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per this DEPR: openedx/public-engineering#34 This was a temporary waffle and is no longer needed. BREAKING_CHANGE: Setting the `block_structure.raise_error_when_not_found` waffle switch via django-waffle will be ignored. Note for Operators: If you have this waffle swicth in your systems, it should be removed.
|
@openedx/site-reliability-engineering tagging you since you run off of master and this removes a setting that you may want to cleanup from the LMS WaffleSwitch table if it's there. |
feanil
force-pushed
the
feanil/depr_bs_raise_error
branch
2 times, most recently
from
7658e1a
to
c1c2496
Compare
Various tests with query counts need to be updated now that we have removed a waffle check that was in their codepath.
feanil
force-pushed
the
feanil/depr_bs_raise_error
branch
from
c1c2496
to
40eedc6
Compare
dianakhuang
approved these changes
Jan 27, 2023
|
Thanks for the review @dianakhuang I'll be merging it on Monday Morning. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per this DEPR: openedx/public-engineering#34
This was a temporary waffle and is no longer needed.
BREAKING_CHANGE: Setting the
block_structure.raise_error_when_not_foundwaffle switch viadjango-waffle will be ignored.
Note for Operators: If you have this waffle swicth in your systems, it
should be removed.