Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove relative due date limit #32094

Conversation

Agrendalath
Copy link
Member

Description

The due date limit is artificially enforced by the frontend. The backend does not have limitations that would prevent it from using a higher value. Having this limit leads to the bug described in the "Testing instructions".

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

  1. Add the following Waffle Flags (both enabled):
    1. course_experience.relative_dates
    2. studio.custom_relative_dates.
  2. Create a new course.
  3. Go to "Settings -> Schedule & Details" in Studio and mark the course as "Self-Paced".
  4. Go to "Settings -> Advanced Settings" and set "Number of Relative Weeks Due By" to 999.
  5. Go to the Course Outline in Studio and add a subsection graded as "Homework". Set its "Due in" value to 1024.
  6. The text on the subsection block should be "Custom due date: 1024 weeks from enrollment".

Deadline

"None"

Other information

Private-ref: https://tasks.opencraft.com/browse/BB-7349

@openedx-webhooks
Copy link

Thanks for the pull request, @Agrendalath!

As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion.

@farhaanbukhsh
Copy link
Member

Hey @Agrendalath,

I change the "Number of Relative Weeks Due By" to 999 but now if I go a number below the Save button gets disabled. The save button is active from 1-18.

image

Can you explain the behaviour here? Thanks.

@Agrendalath
Copy link
Member Author

@farhaanbukhsh, I forgot to mention it in the testing instructions, but you should rebuild Studio statics and refresh the browser's cache.

Copy link
Member

@farhaanbukhsh farhaanbukhsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • ✅ I tested this: I have checked the artificial limit is removed and this works well in the devstack.
  • ✅ I read through the code
  • ❌ I checked for accessibility issues
  • ❌ Includes documentation
  • ❌ I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

It was an artificial limit enforced by the frontend. The backend does not have
limitations that would prevent it from using a higher value.
@Agrendalath Agrendalath force-pushed the agrendalath/relatative_due_date_remove_limit branch from 93697b9 to c1a5aef Compare May 4, 2023 13:55
@Agrendalath Agrendalath merged commit e025558 into openedx:master May 4, 2023
44 checks passed
@Agrendalath Agrendalath deleted the agrendalath/relatative_due_date_remove_limit branch May 4, 2023 15:20
@openedx-webhooks
Copy link

@Agrendalath 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core committer open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants