feat: provisionally support V2 libraries in LibraryContentBlock (randomized only) #33263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than implementing V2-library and static-library-reference support in a new block, we will be enhancing the existing `LibraryContentBlock` in-place. Relevant ADR PR: #33231
Co-Authored-By: Connor Haugh <chaugh@2u.com> Co-Authored-By: Eugene Dyudyunov <evgen.dyudyunov@raccoongang.com>
kdmccormick
force-pushed
the
kdmccormick/library-content-v2
branch
from
02bd84a
to
9eee194
Compare
4 tasks
kdmccormick
commented
Sep 14, 2023
xmodule/assets/library_content/public/js/library_content_edit_helpers.js
Show resolved
Hide resolved
xmodule/assets/library_content/public/js/library_content_edit_helpers.js
Show resolved
Hide resolved
...per comment in cms/djangoapps/contentstore/tasks.py.
This fixes an exception that was raised in the background whenever
the update_children_task was started:
Traceback (most recent call last):
File "/openedx/venv/lib/python3.8/site-packages/celery/utils/dispatch/signal.py", line 276, in send
response = receiver(signal=self, sender=sender, **named)
File "/openedx/venv/lib/python3.8/site-packages/user_tasks/signals.py", line 215, in start_user_task
sender.status.start()
File "/openedx/venv/lib/python3.8/site-packages/user_tasks/tasks.py", line 84, in status
name = self.generate_name(arguments_dict)
File "/openedx/edx-platform/openedx/core/djangoapps/content_libraries/tasks.py", line 274, in generate_name
key = arguments_dict['dest_block_key']
KeyError: 'dest_block_key'
This was referenced Oct 6, 2023
This was referenced Oct 17, 2023
Just like ./common/ and ./openedx/, the unit tests in ./xmodule/
validate behavior in both LMS and CMS. In order to fully test
./xmodule/, we need to run its tests in both contexts.
Also in this commit:
* refactor: Rename the shards to be clear whether they're
running under LMS or CMS.
* docs: correct comments regarding conditions under which
codejail's test_cant_do_something_forbidden is skipped.
* test: update a unit test which was using the now-deleted
library_sourced block to use library_content block instead.
|
Sandbox deployment failed. Please check the settings and requirements and retry deployment. |
|
Sandbox deployment started. |
|
Sandbox deployment failed. Please check the settings and requirements and retry deployment. |
|
@connorhaugh Unit tests are all set now. The only failing check is a random pylint thing that I can fix Monday. I'll be manually testing this more Monday morning. Assuming the recent commits look good to you and we don't find bugs, let's merge in the afternoon? |
|
@kdmccormick I'm also giving it one final once over. |
kdmccormick
changed the title
auto-merge was automatically disabled
November 20, 2023 15:09
Pull request was closed
|
Sandbox deployment started. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
Sandbox update request received. Deployment will start soon. |
|
Sandbox deployment failed. Please check the settings and requirements and retry deployment. |
|
Sandbox update request received. Deployment will start soon. |
2 similar comments
|
Sandbox update request received. Deployment will start soon. |
|
Sandbox update request received. Deployment will start soon. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
DanielVZ96
pushed a commit
to DanielVZ96/edx-platform
that referenced
this pull request
Nov 25, 2023
…omized only) (openedx#33263) Refactors and reworks the LibraryContentBlock so that its sync-from-library operations are asynchronous and work with V2 content libraries. This also required us to make library_content block duplication asynchronous, as that involves syncing from the source library. For the sake of clarity, this PR includes two major method renames: * update_children(...) -> sync_from_library(...) * refresh_library(...) -> sync_from_library(upgrade_to_latest=True, ...) an an XBlock HTTP handler rename: /refresh_children -> /upgrade_and_sync There are still a couple issues with import or duplication of library_content blocks referencing V2 libraries other than latest. These will be resolved in an upcoming PR. Part of: https://openedx.atlassian.net/wiki/spaces/COMM/pages/3820617729/Spec+Memo+Content+Library+Authoring+Experience+V2 Follow-up work: openedx#33640 Co-authored-by: Connor Haugh <chaugh@2u.com> Co-authored-by: Eugene Dyudyunov <evgen.dyudyunov@raccoongang.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-author credit to @connorhaugh and RaccoonGang.