feat: add new library editor toggle #33628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew-library-block-editor-toggle-to-studio
|
|
|
It doesn't actually block, but blocks from usage. the JS can just sit around unused with no harm caused. |
kdmccormick
requested changes
Dec 12, 2023
There was a problem hiding this comment.
Looks good in general. My only qualm is that this flags toggles the new editor for the library_content component, not the new editor for libraries (which is behind a completely different flag). So, the names should be ENABLE_NEW_LIBRARY_CONTENT_EDITOR_FLAG, use_new_library_content_editor(), etc.
| # .. toggle_use_cases: temporary | ||
| # .. toggle_creation_date: 2023-10-30 | ||
| # .. toggle_target_removal_date: 2025-1-30 | ||
| # .. toggle_tickets: TNL-11040 |
There was a problem hiding this comment.
Link to something public please
…ew-library-block-editor-toggle-to-studio
… github.com:edx/edx-platform into feat--add-new-library-block-editor-toggle-to-studio
connorhaugh
merged commit 5ba4852
into
feat--Library-Content-Block-Reference
63 checks passed
connorhaugh
deleted the
feat--add-new-library-block-editor-toggle-to-studio
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://2u-internal.atlassian.net/browse/TNL-11118
Description
Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.
Useful information to include:
"Developer", and "Operator".
changes.
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.