Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ORA response with attached file (for Quince) #33676

Conversation

DmytroAlipov
Copy link
Contributor

@DmytroAlipov DmytroAlipov commented Nov 8, 2023

This is a backport pull request to the master branch.

Description

The details are described in this discussion.

Now everything works correctly:

Знімок екрана 2023-11-08 о 14 10 40

Do not pay attention to the fact that the screenshot was taken from a local instance. It has been tested on the production server, and everything works just as correctly.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 8, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@DmytroAlipov DmytroAlipov force-pushed the fix-ora-uploaded-response-quince branch 2 times, most recently from d1ed96e to 8775186 Compare November 8, 2023 13:09
@DmytroAlipov DmytroAlipov changed the title fix: ORA response with attached file fix: ORA response with attached file (for Quince) Nov 8, 2023
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Nov 9, 2023
@DmytroAlipov DmytroAlipov force-pushed the fix-ora-uploaded-response-quince branch from 8775186 to 95477ac Compare November 12, 2023 19:52
@mariajgrimaldi
Copy link
Member

Hi there @DmytroAlipov! We usually backport PR(s) after their corresponding master PR is merged. So we'll review this contribution against quince.master once that happens. Thanks!

@DmytroAlipov DmytroAlipov force-pushed the fix-ora-uploaded-response-quince branch from 95477ac to 69612c9 Compare February 6, 2024 20:37
After clicking the "View all responses" button in the
ORA Staff Grading App, an error page appears for ORAs
with file uploads.
@DmytroAlipov DmytroAlipov force-pushed the fix-ora-uploaded-response-quince branch from 69612c9 to b3ea3ce Compare February 6, 2024 20:40
@DmytroAlipov
Copy link
Contributor Author

Hi @mariajgrimaldi
As promised, I have updated the backport 😉

Additionally, I made the update for Palm, but the static check seems not to be functioning there. Does it require fixing? Considering that Palm tags are no longer being cut off.

@mariajgrimaldi
Copy link
Member

@DmytroAlipov: exactly, Palm.4 was the latest tag release so it's not worth it making it work there. I'll let the BTR know about this backport and then merge. Thanks!

@mariajgrimaldi mariajgrimaldi merged commit ba4bcf1 into openedx:open-release/quince.master Feb 7, 2024
43 checks passed
@openedx-webhooks
Copy link

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the fix-ora-uploaded-response-quince branch February 7, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants