Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: freeze edx-sandbox requirements for redwood #34757

Conversation

cmltaWt0
Copy link
Contributor

@cmltaWt0 cmltaWt0 commented May 9, 2024

This is a backport of #34752

We ran:

cp requirements/edx-sandbox/base.txt \
   requirements/edx-sandbox/releases/redwood.txt

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 9, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @cmltaWt0! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@cmltaWt0
Copy link
Contributor Author

cmltaWt0 commented May 9, 2024

@feanil ^

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small documentation request but otherwise looks good.

Comment on lines 57 to 58
releases/redwood.txt
----------------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
releases/redwood.txt
----------------------------------
releases/redwood.txt
--------------------

The underlining should match the title.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label May 9, 2024
We ran:

    cp requirements/edx-sandbox/base.txt \
       requirements/edx-sandbox/releases/redwood.txt
@cmltaWt0 cmltaWt0 force-pushed the max/feat/pip-sandbox-requirements-redwood branch from 8ff52ce to af8454b Compare May 10, 2024 12:59
@cmltaWt0 cmltaWt0 merged commit 351e360 into openedx:open-release/redwood.master May 10, 2024
78 checks passed
@openedx-webhooks
Copy link

@cmltaWt0 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants