New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Switch from edx-sphinx-theme to sphinx-book-theme #261
chore: Switch from edx-sphinx-theme to sphinx-book-theme #261
Conversation
Thanks for the pull request, @xitij2000! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
4cb17bc
to
6f3b721
Compare
a82be95
to
5e66093
Compare
👍
|
e268889
to
22afb04
Compare
Hi @xitij2000! Is this ready for review? If so, would you mind addressing the branch date item in the meantime? Thanks! |
The edx-sphinx theme is being deprecated, and replaced with sphinx-book-theme. This removes references to the deprecated theme and replaces them with the new standard theme for the platform. See https://github.com/openedx/edx-sphinx-theme/issues/184
22afb04
to
646bd13
Compare
Yes, it's ready for review. CC: @feanil I'm not sure what you mean by "addressing the branch date item"? |
@xitij2000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
The edx-sphinx theme is being deprecated, and replaced with sphinx-book-theme. This removes references to the deprecated theme and replaces them with the new standard theme for the platform.
Testing instructions:
make docs
and see that the docs are generated properly and use the sphinx-book-themeSee openedx/public-engineering#200