-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
kill yarn, bump to node 8 #99
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@arizzitano 馃殺 |
bjacobel
reviewed
Jan 11, 2018
@@ -12,7 +12,7 @@ before_install: | |||
|
|||
install: | |||
- rvm install 2.2.2 | |||
- yarn --frozen-lockfile | |||
- npm install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃槶
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO: Link to a JIRA ticket if one has been created for this feature/issue.
Use the following format for a link:
[FEDX-100](https://openedx.atlassian.net/browse/FEDX-100)
TODO: Include a detailed description of the changes in the body of the PR.
TODO: If relevant, provide a URL to updated Pattern Library documentation.
Manual Test Plan
TODO: If your changes require manual tests, include instructions for any required manual tests, and any manual testing that has already been performed.
Testing Checklist
Non-testing Checklist
Post-review
Reviewers
TODO: In this section, tag specific reviewers you know will want to have a look at this PR. You can use the checklist below for organization:
TODO: Consider not just code reviewers but also including reviewers from Docs, UX, Accessibility and Product, if applicable.
If you've been tagged for review, please check your corresponding box once you've given the 馃憤.
We'll also automatically suggest reviewers for this PR based on the code it touches.