Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill yarn, bump to node 8 #99

Merged
merged 4 commits into from
Jan 11, 2018
Merged

kill yarn, bump to node 8 #99

merged 4 commits into from
Jan 11, 2018

Conversation

arizzitano
Copy link
Contributor

Description

TODO: Link to a JIRA ticket if one has been created for this feature/issue.
Use the following format for a link: [FEDX-100](https://openedx.atlassian.net/browse/FEDX-100)

TODO: Include a detailed description of the changes in the body of the PR.

TODO: If relevant, provide a URL to updated Pattern Library documentation.

Manual Test Plan

TODO: If your changes require manual tests, include instructions for any required manual tests, and any manual testing that has already been performed.

Testing Checklist

  • Write unit tests for all new features.
  • Write accessibility (a11y) tests for all new UI.
  • Manually test responsive behavior.

Non-testing Checklist

  • Consider any documentation your change might need, and which users will be affected by this change.
  • Consult with the Pattern Library team if adding a new component.

Post-review

  • Squash commits into discrete sets of changes with descriptive commit messages.

Reviewers

TODO: In this section, tag specific reviewers you know will want to have a look at this PR. You can use the checklist below for organization:

  • @mention a reviewer here
  • @mention a reviewer here

TODO: Consider not just code reviewers but also including reviewers from Docs, UX, Accessibility and Product, if applicable.

If you've been tagged for review, please check your corresponding box once you've given the 馃憤.

We'll also automatically suggest reviewers for this PR based on the code it touches.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.848% when pulling 8efb252 on ari/node-8 into 1863983 on master.

@coveralls
Copy link

coveralls commented Jan 9, 2018

Coverage Status

Coverage remained the same at 98.848% when pulling 7cfde53 on ari/node-8 into 1863983 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.848% when pulling aad196f on ari/node-8 into 1863983 on master.

@yro
Copy link
Contributor

yro commented Jan 11, 2018

@arizzitano 馃殺

@@ -12,7 +12,7 @@ before_install:

install:
- rvm install 2.2.2
- yarn --frozen-lockfile
- npm install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃槶

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor

@arizzitano arizzitano merged commit 0acb7ef into master Jan 11, 2018
@arizzitano arizzitano deleted the ari/node-8 branch January 11, 2018 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants