fix: Use openedx-events 5.0.0 and new custom-metadata method signature #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just follows a breaking API change in openedx-events and should not have any impact on dependents.
rgraber
approved these changes
Feb 3, 2023
I'd like to see CI tests pass *before* I merge and release openedx-events, so I'm giving this approach a shot. (I already know it passes locally if I do a `pip install -e ../openedx-events`, but it would be nice to have a process to follow in the future.)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just follows a breaking API change in openedx-events and should not have any impact on dependents.
Pending:
make upgradewith new openedx-events version, once feat!: Only accept metadata object insend_event_with_custom_metadataopenedx-events#179 is merged and released.Merge checklist:
Check off if complete or not applicable: