Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Implement producer API for openedx-events #14

Merged
merged 8 commits into from
Nov 28, 2022
Merged

feat!: Implement producer API for openedx-events #14

merged 8 commits into from
Nov 28, 2022

Conversation

timmc-edx
Copy link
Contributor

@timmc-edx timmc-edx commented Jul 28, 2022 •
edited
Loading

Remove caching of get_producer since openedx-events will take care of
that for us, and rename to create_producer.

This is part of openedx/openedx-events#87

@timmc-edx timmc-edx marked this pull request as ready for review July 28, 2022 21:14
@timmc-edx timmc-edx mentioned this pull request Aug 3, 2022
Closed
4 tasks
@timmc-edx timmc-edx force-pushed the timmc/api branch 2 times, most recently from bb6c2cd to 18c945d Compare August 24, 2022 21:33
@timmc-edx timmc-edx force-pushed the timmc/api branch 2 times, most recently from fb0978d to d48ed94 Compare September 7, 2022 14:18
@timmc-edx timmc-edx mentioned this pull request Nov 18, 2022
Merged
4 tasks
@robrap robrap added the event-bus Work related to the Event Bus. label Nov 18, 2022
@timmc-edx timmc-edx changed the title feat: Implement impl-loading API for openedx-events feat: Implement producer API for openedx-events Nov 21, 2022
@timmc-edx
feat: Implement producer API for openedx-events
a052463 
Remove caching of `get_producer` since openedx-events will take care of
that for us.

This is part of openedx/openedx-events#87
@timmc-edx timmc-edx marked this pull request as draft November 21, 2022 19:31
rgraber
rgraber approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@rgraber rgraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmc-edx timmc-edx marked this pull request as ready for review November 22, 2022 19:16
rgraber
rgraber approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@rgraber rgraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmc-edx timmc-edx changed the title feat: Implement producer API for openedx-events feat!: Implement producer API for openedx-events Nov 28, 2022
@timmc-edx timmc-edx merged commit d9948f8 into main Nov 28, 2022
@timmc-edx timmc-edx deleted the timmc/api branch November 28, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgraber rgraber rgraber approved these changes

Assignees

@timmc-edx timmc-edx

Labels
event-bus Work related to the Event Bus.
Projects
None yet
Milestone
[Event Bus] Production ready event
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timmc-edx @rgraber @robrap