Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make use of abstract consumer API #13

Merged
merged 4 commits into from
May 4, 2023

Conversation

navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented Apr 13, 2023

Description: Removes local consume_events command and instead makes use of new abstract consumer API and the command from openedx-events to start a worker.

JIRA: Private-ref: BB-7240

Issue: openedx/openedx-events#147

Dependencies: openedx/openedx-events#200

Merge deadline: List merge deadline (if any)

Installation instructions: and Testing instructions:

Follow instructions from readme. The consume_events command is provided by openedx-events and the RedisEventConsumer is loaded from test_settings.EVENT_BUS_CONSUMER.

Reviewers:

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 13, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

@kaustavb12 kaustavb12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: Followed testing instruction
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@mphilbrick211
Copy link

Hi @navinkarkera! Is this PR ready for review/merge?

@navinkarkera
Copy link
Contributor Author

@mphilbrick211 Thanks for checking. This MR is dependent on openedx/openedx-events#200, so I'll update and ping once it is ready.

requirements/base.txt Outdated Show resolved Hide resolved
requirements/dev.txt Outdated Show resolved Hide resolved
requirements/doc.txt Outdated Show resolved Hide resolved
requirements/quality.txt Outdated Show resolved Hide resolved
requirements/test.txt Outdated Show resolved Hide resolved
@navinkarkera
Copy link
Contributor Author

@bmtcril This is ready to be merged. We will need to release our first version to pypi in order to make use of this library in openedx and discovery.

PS: I have also made the consumer argument required.

Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! I'll make a release now 🤞

@bmtcril bmtcril merged commit 9674af5 into openedx:main May 4, 2023
8 checks passed
@openedx-webhooks
Copy link

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@navinkarkera
Copy link
Contributor Author

@bmtcril Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants