feat: Make xAPI User Identifier configurable #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziafazal
force-pushed
the
ziafazal/agent-ifi-type
branch
from
c9a2d52
to
319e72a
Compare
bmtcril
reviewed
Apr 5, 2023
| user = get_user(username_or_id) | ||
|
|
||
| if not user: | ||
| logger.info('User with username "%s" does not exist.', username_or_id) |
There was a problem hiding this comment.
I'm slightly concerned about this case. I can see it happening in the event of log replay with retired users, who get their username changed, but can you think of any other case where it may happen? If it's only retired users, we may be able to change the username case in get_user to use this to make the user consistent: https://github.com/openedx/edx-platform/blob/bf36c429509b92854799d5d9b5203b4eb9d7e0df/common/djangoapps/student/models/user.py#L317
There was a problem hiding this comment.
@bmtcril I can't think of anyother use case. I have a added a check to get retired user if user is not found in normal flow.
ziafazal
force-pushed
the
ziafazal/agent-ifi-type
branch
from
3b11356
to
c0fdde7
Compare
fix: improved test coverage fix: updated changelog and fix test feat: get potentially retired user fix: fix quality violations fix: quality violation fix: improve test coverage
ziafazal
force-pushed
the
ziafazal/agent-ifi-type
branch
from
c0fdde7
to
231b11a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has changes to make user identifier in xAPI events configurable. We have introduced a new setting
XAPI_AGENT_IFI_TYPEto make it configurable.This setting can be used to specify the type of inverse functional identifier for actor in xAPI statements. Possible values are
external_id,mbox_sha1sumandmboxwhen we set it to
external_idxAPI statement would represent actor like thissetting it to
mboxxAPI statement would represent actor like thissetting it to
mbox_sha1sumxAPI statement would represent actor like thisImplements #258