fix: Many retries when an LRS returns a 409 error #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 409 error code is returned when an LRS determines a statement id already exists in the database, which is a use case we will see a lot with the new idempotent statement ids and upcoming tracking log replay. This change logs and eats that error.
The 409 error code is returned when an LRS determines a statement id already exists in the database, which is a use case we will see a lot with the new idempotent statement ids and upcoming tracking log replay. This change logs and eats that error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The 409 error code is returned when an LRS determines a statement id already exists in the database, which is a use case we will see a lot with the new idempotent statement ids and upcoming tracking log replay. This change logs and eats that error.
This was introduced here:
https://github.com/openedx/event-routing-backends/pull/290/files
Issue: #295
Merge deadline: ASAP as this has a multiplicative effect for each failing event which (in older versions) is compounded by this issue: #296
Testing instructions:
Currently this is easy to test in a Nutmeg Tutor install given the other issue with the idempotent ids.
Merge checklist:
Post merge:
finished.
Author concerns: This is a draft PR just to get @ziafazal 's eyes on it before I put more work into making the tests work. It may not be the correct way to go so I'd like his input.