fix: Caliper transform of video events without duration #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmtcril
force-pushed
the
bmtcril/fix_caliper_no_duration
branch
from
e3683c3
to
7dcaa05
Compare
ziafazal
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
@bmtcril I think we can reproduce error if set duration attribute in any of the video interaction events like edx.video.closed_captions.hidden to null. It appears some of the events in tracking log had duration set to null which caused that error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixes #310 which was reported here: #301 (review)
Author concerns: I wasn't able to test this, or write a new test for it since it seems like an existing test should have already caught this. I'm not quite sure what the difference was in @ziafazal 's test, but this change seems harmless and obviously worked for him.