Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use one configuration for all backends #411

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Apr 1, 2024

Description: This PR updates the configuration to only use 1 setting entry for both backends.

This is a proposal, and depends on: openedx/event-tracking#273

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 1, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 1, 2024

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012
Copy link
Contributor Author

Ian2012 commented Apr 1, 2024

@ziafazal @bmtcril is this suitable for our requirements?

This way, switching backends would be a lot easier

Copy link
Contributor

@ziafazal ziafazal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ian2012 I'm fine with using single backend how name of that backend should not be just events I have suggested couple of names in other comment.

event_routing_backends/settings/common.py Outdated Show resolved Hide resolved
@Ian2012 Ian2012 marked this pull request as ready for review April 2, 2024 15:59
@Ian2012 Ian2012 marked this pull request as draft April 2, 2024 16:08
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had the one request, otherwise it looks good to me

@Ian2012 Ian2012 marked this pull request as ready for review April 2, 2024 17:23
@Ian2012 Ian2012 merged commit 8721ce8 into master Apr 2, 2024
10 checks passed
@Ian2012 Ian2012 deleted the cag/erb-settings branch April 2, 2024 20:15
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants