Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use event_transformer as backend name #416

Merged
merged 3 commits into from
Apr 25, 2024
Merged

fix: use event_transformer as backend name #416

merged 3 commits into from
Apr 25, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Apr 25, 2024

Description: This PR fixes a bug in the default settings that makes the celery task unable to find the proper backend to send the events:

[2024-04-24 21:14:26,824: ERROR/ForkPoolWorker-17] eventtracking.tasks.send_event[b850c5f5-3fbe-4039-a4f6-6fd23d3466bd]: [send_event] Failed to send event [pause_video] with backend [events], [KeyError('events')]

This error started appearing after the upgrade to v9.0.0 where the settings were merged into a single entry.

JIRA: Link to JIRA ticket

Dependencies: dependencies on other outstanding PRs, issues, etc.

Merge deadline: List merge deadline (if any)

Installation instructions: List any non-trivial installation
instructions.

Testing instructions:

  1. Open page A
  2. Do thing B
  3. Expect C to happen
  4. If D happened instead - check failed.

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 25, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Ian2012 and others added 2 commits April 25, 2024 10:27
* build: replace codecov with python-coverage-comment-action

* build: update codecov action to use repo-specific tokens
@bmtcril bmtcril merged commit a09e875 into master Apr 25, 2024
10 checks passed
@bmtcril bmtcril deleted the cag/fix branch April 25, 2024 15:48
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants