feat: call set_code_owner_attribute_from_module directly in send_task #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robrap
reviewed
Oct 27, 2021
|
@rgraber: Also, won't we need to update the version? |
robrap
reviewed
Oct 27, 2021
…ub.com/edx/event-tracking into rsgraber/ARCHBOM-1938-track-code-owner
robrap
approved these changes
Oct 27, 2021
rgraber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update send_task to call set_code_owner_attribute_from_module directly instead of using the annotation to add the code owner. Addresses https://openedx.atlassian.net/browse/ARCHBOM-1938.
Post-merge update: on further examination, it's possible this change was unnecessary and that it was fixed in a previous change that was simply unreleased, but it did not seem worth the time or complexity to roll back when this updated code should effectively do the same thing.